-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] remove Visual Studio 2017 CI job for R-package #5079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah! That's my fault, sorry I missed that!
Could the Visual Studio 2019
MSVC job be changed to r_version: 3.6
? So that we still have coverage of building for R 3.6 with MSVC?
@jameslamb Great point, thanks! Done in 779b007. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this!
closing and re-opening to re-trigger CI. I'm not sure why GitHub Actions didn't run. |
Woohoo!!! Finally they did it! 🚀 |
ahhhh excellent! That's really exciting. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Closed #4748.
Related: #5059.
Sorry, I missed in #5059 the point that GitHub Actions shares the same environments with Azure Pipelines.
actions/runner-images#4312
actions/runner-images#5238