-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] fix broken SynapseML link #4712
Conversation
@jameslamb sounds good to me, sorry about breaking you so often! Also FYI @serena-ruan |
no problem, just wanted you to be aware! |
@jameslamb Maybe we can just remove |
Yeah I agree! Good point. I just pushed a commit removing that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
SynapseML (formerly MMLSpark) maintainers recently did another docs re-organization (microsoft/SynapseML#1221), and as a result a link in LightGBM's documentation is currently broken.
From the most recent
check-links
job.reference: https://github.com/microsoft/LightGBM/runs/3987915929?check_suite_focus=true
This has happened several times over the last year:
To fix the broken link and avoid disruptions from future re-organizations in SynapseML, this PR proposes replacing the LightGBM-specific link that is now broken to just link to the root of the SynapseML repo instead.
cc @imatiach-msft