Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve @fluidframework/test-client-utils API docs #10591

Merged
merged 21 commits into from
Jun 24, 2022

Conversation

Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Jun 7, 2022

Improve @fluidframework/test-client-utils API docs

The intention behind this PR is to improve API documentation on the consumer-facing APIs of the @fluidframework/test-client-utils package. It also includes some changes in transitively exposed APIs from packages upon which it depends.

See here for the public-facing, generated docs: https://fluidframework.com/docs/apis/test-client-utils/

The TODOs and comments I left are in search of suggestions from area experts. If you are reviewing this and know of someone who would have expertise and/or opinions on the docs, please feel free to tag them :)

ADO #643

@github-actions github-actions bot added area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues base: main PRs targeted against main branch labels Jun 7, 2022
@Josmithr Josmithr requested a review from ssimic2 June 7, 2022 23:42
@github-actions github-actions bot added the public api change Changes to a public API label Jun 8, 2022
@Josmithr Josmithr requested a review from skylerjokiel June 8, 2022 18:33
Copy link
Contributor

@skylerjokiel skylerjokiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

common/lib/protocol-definitions/src/users.ts Outdated Show resolved Hide resolved
@Josmithr Josmithr marked this pull request as ready for review June 13, 2022 20:41
@Josmithr Josmithr requested review from a team as code owners June 13, 2022 20:41
@Josmithr Josmithr requested a review from a team as a code owner June 17, 2022 20:24
Copy link
Contributor

@skylerjokiel skylerjokiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more recommendation

packages/drivers/routerlicious-driver/src/tokens.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast /home/runner/work/FluidFramework/FluidFramework/docs
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt "--external"

Crawling...

http://localhost:1313/css/style.min.f22f6c22fcc37a0d857a17c9c1202a67c28deef90cc26a52b7539b903f623331.css
- (1:1031) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/light/latest.svg (HTTP 503)
- (1:1272) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.eot? (HTTP 503)
- (1:1634) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.ttf (HTTP 503)
- (1:1740) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semilight/latest.svg (HTTP 503)
- (1:2427) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/normal/latest.svg (HTTP 503)
- (1:3130) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/semibold/latest.svg (HTTP 503)
- (1:3286) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.eot (HTTP 503)
- (1:3710) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.ttf (HTTP 503)
- (1:3811) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.svg (HTTP 503)


Stats:
   14095 links
     296 destination URLs
       1 URLs ignored
       0 warnings
       9 errors


@Josmithr Josmithr merged commit ae60b59 into microsoft:main Jun 24, 2022
@Josmithr Josmithr deleted the improve-test-client-utils-docs branch June 24, 2022 21:31
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues area: website base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants