preview merge from main #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add negating feature tag evaluation section to readme * reword last sentence * fix ordering and consolidate sections for readability
…275) * update the recommended way to reference feature flag name * remove nameof * remove recommended referencing way * using string literals directly
* allow dup alias & target on main branch * fix bug: non-contextual filter will not be found when there is context * keep using ContextualFeatureFilterEvaluator.IsContextualFilter * fix bug * use typeof & avoid using repeated code * resolve comments & add testcase * resolve comments * remove unnecessary '?' * use var
* register built-in filter first & target on main branch * remove internal keyword * resolve comments * improve the way to register targeting context accessor * fix typo * adjust the way to register targeting context accessor & update testcases * fix typo * move WithTargeting to FeatureManagementBuilderExtension
zhiyuanliang-ms
requested review from
rossgrambo,
amerjusupovic and
jimmyca15
jimmyca15
reviewed
Oct 27, 2023
jimmyca15
approved these changes
Oct 30, 2023
|
@zhiyuanliang-ms please complete with a "merge" commit rather than a squash commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.