Recreates examples with latest packages #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyca15
reviewed
Oct 12, 2023
| @@ -1,12 +1,7 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // Licensed under the MIT license. | |||
| // | |||
| using Consoto.Banking.AccountService.FeatureFilters; | |||
|
|
|||
| namespace Consoto.Banking.AccountService | |||
There was a problem hiding this comment.
The ConsoleApp and other VS templates now defaults to https://aka.ms/new-console-template
Namespace automatically matches the project name. I left the namespace, "class Program", "Main" scaffolding in some of the Examples, but wanted to use the new console template in at least a few places to better match the new template. ConsoleApp makes the most sense to be minimalistic to me.
rossgrambo
force-pushed
the
rossgrambo/example-dependency-update
branch
from
d6720ea
to
651ed76
Compare
jimmyca15
approved these changes
Oct 12, 2023
| @@ -17,7 +17,7 @@ public Task HandleDisabledFeatures(IEnumerable<string> features, ActionExecuting | |||
| { | |||
| var result = new ViewResult() | |||
| { | |||
| ViewName = "Views/Shared/FeatureNotEnabled.cshtml", | |||
| ViewName = "Pages/Shared/FeatureNotEnabled.cshtml", | |||
There was a problem hiding this comment.
There is no "Pages" folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.