Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove null byte from PEM files #3885

Merged
merged 8 commits into from
May 25, 2022
Merged

Remove null byte from PEM files #3885

merged 8 commits into from
May 25, 2022

Conversation

eddyashton
Copy link
Member

This was required for mbedtls, but not for OpenSSL. Hoping it's this trivial fix, will let the CI confirm.

@eddyashton eddyashton requested a review from a team May 24, 2022 13:39
@ghost
Copy link

ghost commented May 24, 2022 •
edited by ghost
Loading

pem_null_termination@45878 aka 20220525.23 vs main ewma over 20 builds from 45560 to 45846

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
45560 20220518.3 6225 8.40213e+07 19683.5 1.56017e+07 5622.3 1.53396e+07 2543.73 1.00967e+07 1651.58 1.62927e+08 2114.2 9.04813e+06 1435.43 9.89635e+07 1976.19 8.52384e+06 20095 889385 1.35925e+06 9.2335e+06 3.58669e+07
45562 20220518.4 6357.87 8.42835e+07 19426.1 1.58639e+07 5626.1 1.50774e+07 2538.07 1.00967e+07 1631.42 1.63975e+08 2081.33 9.04813e+06 1420.73 9.76528e+07 2014.41 1.03588e+07 21147.9 876819 1.36505e+06 9.42472e+06 3.56168e+07
45582 20220518.7 6129.08 8.42835e+07 19433.2 1.63882e+07 5616.88 1.50774e+07 2522.2 1.00967e+07 1589.27 1.63451e+08 2116.46 9.04813e+06 1425.92 9.84392e+07 1915.46 8.78598e+06 21832.5 905628 1.36962e+06 9.29633e+06 3.58669e+07
45594 20220518.9 6041.02 8.32349e+07 20000.4 1.58639e+07 5570.11 1.53396e+07 2533.31 1.00967e+07 1601.56 1.62927e+08 2113.38 9.04813e+06 1418.8 9.84392e+07 1972.07 8.52384e+06 19393.5 903230 1.35065e+06 9.42034e+06 3.57411e+07
45604 20220519.3 6222.87 8.42835e+07 19402.4 1.58639e+07 5481.67 1.6126e+07 2532 1.00967e+07 1621.86 1.62927e+08 2147.49 9.04813e+06 1397.25 9.84392e+07 1915.53 8.78598e+06 17324.1 873230 1.36797e+06 9.48144e+06 3.58669e+07
45614 20220519.6 6192.12 8.37592e+07 19433 1.6126e+07 5571.3 1.53396e+07 2522.34 1.00967e+07 1637.84 1.61092e+08 2115.5 9.04813e+06 1459.62 9.84392e+07 2015.66 8.78598e+06 18324.9 910051 1.37236e+06 9.22099e+06 3.58663e+07
45630 20220519.12 6368.6 8.37592e+07 19537.1 1.6126e+07 5643.55 1.53396e+07 2550.37 1.00967e+07 1644.48 1.63451e+08 2117.59 9.04813e+06 1445.35 9.87014e+07 1976.21 8.78598e+06 17521.4 908561 1.36532e+06 9.22518e+06 3.55549e+07
45667 20220520.2 6364.31 8.37592e+07 19429.6 1.6126e+07 5654.34 1.56017e+07 2546.73 1.00967e+07 1643.53 1.63189e+08 2127.17 1.27181e+07 1416.82 9.81771e+07 1969.98 8.52384e+06 20347.6 868490 1.3253e+06 8.89657e+06 3.58042e+07
45686 20220520.10 6218.85 8.40213e+07 19023.6 1.63882e+07 5607.52 1.56017e+07 2542.14 1.00967e+07 1614 1.62927e+08 2105.53 9.04813e+06 1432.3 9.84392e+07 1970.11 8.78598e+06 17648.9 906746 1.36468e+06 9.22095e+06 3.57411e+07
45706 20220520.17 6181.63 8.29727e+07 19600.7 1.56017e+07 5540.12 1.53396e+07 2441.55 9.83456e+06 1608.85 1.63713e+08 2075.58 1.19317e+07 1435.75 9.81771e+07 1921.45 8.78598e+06 19876.7 886116 1.37329e+06 9.22518e+06 3.58042e+07
45720 20220520.23 5949.82 8.40213e+07 18128.5 1.58639e+07 5270.84 1.58639e+07 2402.87 1.14074e+07 1533.44 1.6083e+08 2018.4 9.04813e+06 1344.38 9.76528e+07 1835.54 8.52384e+06 18681.2 837592 1.28805e+06 8.95888e+06 3.44202e+07
45733 20220523.2 6105.71 8.3497e+07 18945.3 1.6126e+07 5479.22 1.53396e+07 2467.32 1.00967e+07 1612.63 1.63189e+08 2108.26 9.04813e+06 1410.04 9.84392e+07 1917.98 8.78598e+06 21772.8 896859 1.35997e+06 9.27104e+06 3.58042e+07
45748 20220523.9 6129.74 8.37592e+07 19460.3 1.58639e+07 5440.29 1.53396e+07 2486.67 1.00967e+07 1652.29 1.64237e+08 2125.21 9.04813e+06 1451.73 9.79149e+07 1967.16 8.52384e+06 19742.9 904066 1.36441e+06 9.17966e+06 3.59298e+07
45753 20220523.11 6217.15 8.40213e+07 19509.2 1.58639e+07 5529.92 1.56017e+07 2537.74 1.00967e+07 1621.42 1.63189e+08 2114.44 9.04813e+06 1432 9.76528e+07 2014.73 8.52384e+06 19645.7 924557 1.37819e+06 9.45954e+06 3.54325e+07
45767 20220524.2 6239.57 8.32349e+07 19150.3 1.58639e+07 5487.71 1.50774e+07 2532.39 1.00967e+07 1602.37 1.63189e+08 2113.92 9.04813e+06 1417.3 9.73907e+07 1925.65 1.14074e+07 20186.1 884202 1.36852e+06 9.2293e+06 3.48893e+07
45799 20220524.18 6307.13 8.32349e+07 19508.8 1.58639e+07 5503.43 1.53396e+07 2553.5 1.00967e+07 1610.5 1.6083e+08 2122.98 9.04813e+06 1441.94 9.81771e+07 1935.17 8.78598e+06 17484.8 909731 1.37375e+06 9.18382e+06 3.55556e+07
45808 20220524.22 6061.22 8.32349e+07 19712.5 1.58639e+07 5591.2 1.53396e+07 2550.48 1.00967e+07 1617.45 1.62927e+08 2128.53 9.04813e+06 1436.72 9.79149e+07 1947.1 8.78598e+06 17092.6 870188 1.37912e+06 9.21688e+06 3.58663e+07
45825 20220525.2 6293.42 8.42835e+07 19376.6 1.58639e+07 5917.08 1.56017e+07 2532.78 1.00967e+07 1644.88 1.63713e+08 2115.69 9.04813e+06 1410.51 9.79149e+07 1975.42 9.04813e+06 19444.3 906750 1.37541e+06 9.24601e+06 3.58042e+07
45829 20220525.4 6457.01 8.3497e+07 19375.1 1.58639e+07 5582.26 1.53396e+07 2386.61 1.00967e+07 1672.46 1.63451e+08 2120.86 9.04813e+06 1449.52 9.84392e+07 1970.49 8.78598e+06 19845.4 860173 1.37532e+06 9.04586e+06 3.57417e+07
45846 20220525.10 6278.64 8.29727e+07 19375.8 1.6126e+07 5589.04 1.53396e+07 2541.01 1.00967e+07 1637.88 1.63713e+08 2033.74 9.04813e+06 1387.81 9.79149e+07 1976.48 8.78598e+06 17520 914198 1.39016e+06 9.18794e+06 3.56788e+07

pem_null_termination

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
45791 20220524.14 6293.54 8.3497e+07 19441.6 1.58639e+07 5483.98 1.50774e+07 2549.07 1.00967e+07 1616.45 1.63189e+08 2115.54 9.04813e+06 1438.02 9.81771e+07 1932.31 8.78598e+06 17493.2 903829 1.37726e+06 9.44641e+06 3.53713e+07
45844 20220525.9 6372.77 8.40213e+07 19479.9 1.63882e+07 5641.37 1.50774e+07 2597.6 1.00967e+07 1649.81 1.63451e+08 2122.36 9.04813e+06 1389.47 9.81771e+07 1985.47 8.78598e+06 21306.3 896197 1.38172e+06 9.31324e+06 3.58669e+07
45856 20220525.14 6388.98 8.40213e+07 19649.3 1.66503e+07 5545.35 1.56017e+07 2536.39 1.03588e+07 1628.55 1.63451e+08 2126.28 9.04813e+06 1437.62 9.84392e+07 1976.33 8.52384e+06 19107.3 908521 1.37754e+06 9.49462e+06 3.63766e+07
45878 20220525.23 7202.91 8.32349e+07 19586.3 1.58639e+07 5600.61 1.53396e+07 2546.16 1.00967e+07 1622.33 1.63189e+08 2158.14 9.04813e+06 1438.36 9.81771e+07 1931.54 8.52384e+06 21245.2 902514 1.36678e+06 9.27528e+06 3.48893e+07

images

@eddyashton eddyashton merged commit 722c8f9 into microsoft:main May 25, 2022
@wintersteiger wintersteiger mentioned this pull request May 31, 2022
Open
@jumaffre jumaffre added 2.x-todo PRs which should be backported to 2.x auto-backport Automatically backport this PR to LTS branch labels Jun 28, 2022
@github-actions
Copy link

💔 All backports failed

Status Branch Result
❌ release/2.x Backport failed because of merge conflicts

You might need to backport the following PRs to release/2.x:
- Release notes for 2.0 final (#3849)
- Add new JS application runtime docker image (#3845)
- Rename App and CI container images (#3839)

Manual backport

To create the backport manually run:

backport --pr 3885

Questions ?

Please refer to the Backport tool documentation

jumaffre pushed a commit to jumaffre/CCF that referenced this pull request Jun 28, 2022
@eddyashton
Remove null byte from PEM files (microsoft#3885)
fe0617b 
(cherry picked from commit 722c8f9)
@jumaffre jumaffre mentioned this pull request Jun 28, 2022
Merged
@jumaffre jumaffre added the backported This PR was successfully backported to LTS branch label Jun 28, 2022
jumaffre added a commit that referenced this pull request Jun 28, 2022
@jumaffre @eddyashton
Remove null byte from PEM files (#3885) (#3990)
272f14a 
(cherry picked from commit 722c8f9)

Co-authored-by: Eddy Ashton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumaffre jumaffre jumaffre approved these changes

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
2.x-todo PRs which should be backported to 2.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddyashton @achamayou @jumaffre