Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename App and CI container images #3839

Merged
merged 14 commits into from
May 17, 2022
Merged

Rename App and CI container images #3839

merged 14 commits into from
May 17, 2022

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented May 16, 2022

Rename app and CI container images to align with Microsoft naming convention.

  • ccf-sgx-app-dev becomes public/ccf/app/dev:<tag>-sgx
  • ccf-sgx-app-run becomes public/ccf/app/run:<tag>-sgx
  • ccf-sgx-ci becomes ccf/ci/sgx (note that we specify sgx in image name rather than tag as the tag for this image is deduced from a git tag on this repo)
  • The :latest tag is replaced with :lts-devcontainer.

@jumaffre jumaffre added the 2.x-todo PRs which should be backported to 2.x label May 16, 2022
@jumaffre jumaffre marked this pull request as ready for review May 16, 2022 16:01
@jumaffre jumaffre requested a review from a team as a code owner May 16, 2022 16:01
@achamayou
Copy link
Member

@jumaffre can we have an entry in the changelog for this?

@ccf-bot
Copy link
Collaborator

ccf-bot commented May 16, 2022

rename_containers@45478 aka 20220517.7 vs main ewma over 20 builds from 45233 to 45458

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
45233 20220509.20 6148.25 8.40213e+07 18814.8 1.63882e+07 5361.61 1.53396e+07 2480.31 1.00967e+07 1600.81 1.63189e+08 2114.2 9.04813e+06 1411.28 9.81771e+07 2019.61 8.78598e+06 17186.4 878137 1.38725e+06 9.05385e+06 3.56174e+07
45243 20220509.24 7223.14 8.3497e+07 19102.2 1.6126e+07 5558.96 1.50774e+07 2543.45 1.00967e+07 1633.31 1.62927e+08 2121.03 1.08831e+07 1434.56 9.84392e+07 1976.62 8.52384e+06 18630.9 881190 1.39432e+06 9.43766e+06 3.65708e+07
45245 20220509.25 6416.17 8.27106e+07 19491.6 1.58639e+07 5662.7 1.50774e+07 2557.16 1.00967e+07 1660.22 1.62927e+08 2163.09 9.04813e+06 1461.99 9.81771e+07 2020.29 8.52384e+06 19769.2 900254 1.37127e+06 9.23767e+06 3.57417e+07
45252 20220510.2 6317.73 8.40213e+07 19498.4 1.63882e+07 5552.06 1.53396e+07 2545.47 1.00967e+07 1642.75 1.62665e+08 2126.47 9.04813e+06 1457.6 9.87014e+07 2021.95 9.04813e+06 17345.5 907958 1.37035e+06 9.30901e+06 3.58669e+07
45256 20220510.4 5814.08 8.45456e+07 19225.8 1.6126e+07 5265.81 1.53396e+07 2470.85 1.00967e+07 1638.35 1.62927e+08 2082.68 9.31027e+06 1411.66 9.84392e+07 1971.22 8.78598e+06 19721.6 908480 1.36387e+06 9.28794e+06 3.54933e+07
45261 20220510.6 6244.08 8.32349e+07 19416.4 1.63882e+07 5643.71 1.53396e+07 2560.64 1.00967e+07 1617.61 1.63189e+08 2131.16 9.04813e+06 1447.96 9.63421e+07 1843.63 8.78598e+06 19118.9 902793 1.39756e+06 9.20855e+06 3.58042e+07
45269 20220510.10 6286.83 8.40213e+07 19428.6 1.6126e+07 5418.25 1.50774e+07 2547.29 1.03588e+07 1635.54 1.62665e+08 2126.03 9.04813e+06 1452.95 9.81771e+07 1927.06 8.78598e+06 19672.3 904148 1.35862e+06 9.20855e+06 3.58036e+07
45274 20220510.12 6290.23 8.3497e+07 19926 1.56017e+07 5637.18 1.50774e+07 2535.2 1.00967e+07 1618.48 1.6083e+08 2127.75 9.04813e+06 1432.55 9.81771e+07 2004.96 8.78598e+06 19707 893459 1.37819e+06 9.20445e+06 3.58042e+07
45286 20220511.3 6364.53 8.37592e+07 19235.8 1.63882e+07 5649.53 1.53396e+07 2562.43 1.00967e+07 1657.88 1.62927e+08 2124.69 9.04813e+06 1444.5 9.81771e+07 2020.4 8.78598e+06 22261 911755 1.38649e+06 9.22099e+06 3.56794e+07
45308 20220511.11 6143.68 8.42835e+07 19190.4 1.56017e+07 5650.09 1.56017e+07 2533.51 1.00967e+07 1628.68 1.63451e+08 2117.24 9.04813e+06 1428.3 9.73907e+07 1970.62 8.78598e+06 19227.4 904868 1.36188e+06 9.20445e+06 3.59292e+07
45314 20220511.13 6317.83 8.40213e+07 19437.7 1.66503e+07 5561.8 1.58639e+07 2387.15 1.00967e+07 1626.16 1.62927e+08 2112.87 9.31027e+06 1439.51 9.79149e+07 2005.59 8.52384e+06 17341.5 907996 1.36061e+06 9.24601e+06 3.62478e+07
45324 20220512.3 6292.29 8.37592e+07 19413.4 1.63882e+07 5606.76 1.53396e+07 2543.9 1.00967e+07 1617.97 1.62665e+08 2126.35 9.04813e+06 1438.54 9.76528e+07 2011.55 8.78598e+06 19729 904589 1.34816e+06 9.19619e+06 3.5189e+07
45327 20220512.5 6117.44 8.37592e+07 19496.9 1.58639e+07 5610.56 1.53396e+07 2543.63 1.03588e+07 1664.46 1.63189e+08 2122.54 9.04813e+06 1440.44 9.81771e+07 1969.79 8.78598e+06 19425.1 895882 1.38368e+06 9.27108e+06 3.54939e+07
45337 20220512.9 6167.8 8.32349e+07 19037.8 1.63882e+07 5639.77 1.53396e+07 2541.23 1.00967e+07 1629 1.63189e+08 2118.96 9.04813e+06 1446.31 9.81771e+07 1922.28 1.08831e+07 21575.5 878105 1.35746e+06 9.19623e+06 3.50685e+07
45344 20220513.1 5960.46 8.55942e+07 20042.7 1.66503e+07 5646.11 1.50774e+07 2539.89 1.00967e+07 1600.23 1.6083e+08 2114.75 9.04813e+06 1442.47 9.81771e+07 1932.05 8.78598e+06 19546.5 892059 1.40091e+06 9.19619e+06 3.56794e+07
45353 20220513.6 6226.72 8.55942e+07 19068.5 1.69124e+07 5605.86 1.50774e+07 2588.55 1.00967e+07 1594.51 1.63189e+08 2111.69 9.04813e+06 1410.43 9.81771e+07 1934.28 8.52384e+06 21951.9 882333 1.37652e+06 9.20859e+06 3.58669e+07
45363 20220516.3 6352.8 8.3497e+07 19490.6 1.69124e+07 5636.86 1.53396e+07 2558.6 1.00967e+07 1655.54 1.61092e+08 2131.19 9.04813e+06 1465.37 9.84392e+07 1936.53 8.78598e+06 17780.9 909207 1.35908e+06 9.22518e+06 3.56794e+07
45431 20220516.16 6363.59 8.45456e+07 19479.9 1.71746e+07 5559.39 1.56017e+07 2544.15 1.00967e+07 1602.12 1.63189e+08 2070.54 9.04813e+06 1423.73 9.81771e+07 1931.99 8.78598e+06 19313.4 911184 1.36678e+06 9.45513e+06 3.58036e+07
45448 20220516.20 6341.2 8.40213e+07 19370.9 1.6126e+07 5640.37 1.56017e+07 2497.31 1.00967e+07 1674.41 1.63189e+08 2120.59 9.04813e+06 1445.92 9.84392e+07 1969.79 8.78598e+06 21880 900570 1.36305e+06 9.30905e+06 3.22008e+07
45458 20220517.1 6190.26 8.40213e+07 19545.8 1.6126e+07 5524.26 1.50774e+07 2534.03 1.00967e+07 1618.19 1.63189e+08 2112.88 9.04813e+06 1432.27 9.89635e+07 1928.43 8.78598e+06 19620.1 906266 1.35961e+06 9.39868e+06 3.45363e+07

rename_containers

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
45435 20220516.17 6217.01 8.40213e+07 19260.8 1.69124e+07 5520.16 1.53396e+07 2546.58 1.03588e+07 1621.48 1.61092e+08 2124.64 9.04813e+06 1443.83 9.63421e+07 1971.25 8.52384e+06 21194.1 909530 1.37819e+06 9.20441e+06 3.58036e+07
45452 20220516.21 6400.57 8.37592e+07 19639.3 1.6126e+07 5675.58 1.50774e+07 2471.23 1.00967e+07 1638.76 1.63189e+08 2118.76 9.04813e+06 1444.58 9.76528e+07 1942.24 8.78598e+06 19092 904189 1.37597e+06 9.27532e+06 3.58669e+07
45466 20220517.4 5909.82 8.40213e+07 17013.1 1.6126e+07 5047.75 1.56017e+07 2553.51 1.00967e+07 1295.35 1.61616e+08 2022.11 1.16696e+07 1403.38 9.79149e+07 1922.3 8.52384e+06 19514.7 890812 1.37163e+06 9.1961e+06 3.55549e+07
45471 20220517.5 6153.23 8.40213e+07 19288.1 1.58639e+07 5536.75 1.53396e+07 2525.78 1.03588e+07 1591.34 1.61092e+08 2109.37 9.04813e+06 1419.32 9.84392e+07 1918.79 8.78598e+06 19078.4 924464 1.38273e+06 9.18369e+06 3.59292e+07
45478 20220517.7 6109.42 8.42835e+07 19478.2 1.58639e+07 5534.37 1.53396e+07 2528.47 1.00967e+07 1603.12 1.63189e+08 2114.28 9.04813e+06 1401.5 9.63421e+07 1926.06 8.78598e+06 19298.8 883434 1.3754e+06 9.17139e+06 3.58663e+07

images

@jumaffre
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@achamayou
Copy link
Member

I feel that we should take this opportunity to axe latest, which was already slightly non-sensically flipping between 1.x and 2.x, but may now do that between sgx and other archs.

@jumaffre jumaffre enabled auto-merge (squash) May 17, 2022 11:02
@jumaffre jumaffre merged commit dfb7d1e into main May 17, 2022
@jumaffre jumaffre deleted the rename_containers branch May 17, 2022 11:15
jumaffre added a commit to jumaffre/CCF that referenced this pull request May 17, 2022
@github-actions
Copy link

💔 All backports failed

Status Branch Result
release/2.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 3839

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

achamayou pushed a commit to achamayou/CCF that referenced this pull request Nov 11, 2022
(cherry picked from commit dfb7d1e)

# Conflicts:
#	.azure-pipelines-gh-pages.yml
#	.azure-pipelines-v8.yml
#	.azure-pipelines.yml
#	.daily.yml
#	.devcontainer/devcontainer.json
#	.github/workflows/ci-checks.yml
#	.github/workflows/containers.yml
#	.multi-thread.yml
#	.stress.yml
#	CHANGELOG.md
#	doc/contribute/build_images.rst
#	doc/contribute/build_setup.rst
#	doc/operations/run_setup.rst
@achamayou achamayou added the backported This PR was successfully backported to LTS branch label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x-todo PRs which should be backported to 2.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants