Fix sub-hour for dateToLocaleISOString #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclundgren
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
compulim
changed the title
added 2 commits
March 30, 2024 16:31
…adjusted to dec 31s 1999 in this test example
marclundgren
force-pushed
the
marclundgren/dateToLocaleISOString-bufix
branch
from
b69f06b
to
546a64e
Compare
|
Need to update |
|
Will help you out on CHANGELOG.md if I have some spare time today. |
compulim
approved these changes
Apr 7, 2024
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 7, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
dateToLocaleISOStringis returning an invalid value #5080 by ensuring a negative timezone offset will adjust the date accurately.Description
This pull request addresses an issue with the dateToLocaleISOString function, which was generating incorrect values for time zones that have negative offsets, especially those with an additional 30-minute component, such as Newfoundland, Canada. The underlying problem was traced back to the incorrect calculation of the minutes portion of the date for negative offsets, failing to accurately represent the absolute value.
CHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)