Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dateToLocaleISOString is returning an invalid value #5080

Closed
compulim opened this issue Mar 19, 2024 · 0 comments · Fixed by #5114 · 4 remaining pull requests
Closed

dateToLocaleISOString is returning an invalid value #5080

compulim opened this issue Mar 19, 2024 · 0 comments · Fixed by #5114 · 4 remaining pull requests
Labels
bug Indicates an unexpected problem or an unintended behavior. icm Linked from IcM

Comments

@compulim
Copy link
Contributor

compulim commented Mar 19, 2024

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

Browser: Edge (latest), Browser: Chrome (latest), Browser: Firefox (latest), Browser: Safari (latest), Browser: IE Mode (latest), Platform: Windows, Platform: macOS, Platform: iOS/iPadOS, Platform: Android

Which area does this issue affect?

Others or unrelated

What is the public URL for the website?

No response

Please describe the bug

In some environments (timezone with 30 minutes offset), the dateToLocaleISOString return an invalid value of "2024-03-01T09:37:32.086-03:-30". Probably something around https://github.com/microsoft/BotFramework-WebChat/blob/main/packages/core/src/utils/dateToLocaleISOString.ts#L51.

We build this function because the built-in Date.prototype.toISOString() always return UTC and does not contains timezone information.

Do you see any errors in console log?

No response

How to reproduce the issue?

(TBD)

What do you expect?

The function returns '2024-03-01T09:37:32.086-03:30'.

What actually happened?

The function returns '2024-03-01T09:37:32.086-03:-30'.

Do you have any screenshots or recordings to repro the issue?

No response

Adaptive Card JSON

No response

Additional context

Related to ticket 477126826.

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. icm Linked from IcM and removed customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Mar 19, 2024
This was referenced Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment