-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp Announce limitation #3708
Merged
corinagum
merged 9 commits into
microsoft:master
from
amal-khalaf:amal/a11y_group_timestamp_doc
Feb 9, 2021
Merged
Timestamp Announce limitation #3708
corinagum
merged 9 commits into
microsoft:master
from
amal-khalaf:amal/a11y_group_timestamp_doc
Feb 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amal-khalaf
requested review from
a-b-r-o-w-n,
beyackle,
compulim,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
February 4, 2021 19:17
corinagum
reviewed
Feb 4, 2021
corinagum
reviewed
Feb 4, 2021
corinagum
reviewed
Feb 4, 2021
corinagum
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending comments!
Co-authored-by: Corina <[email protected]>
Co-authored-by: Corina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3616
Changelog Entry
Description
Adding documentation to the grouped time stamp announced limitation
where once a live region element is written to the DOM and marked with aria attribute to be logged
it is added to narration queue so even if we removed the element from the DOM later on it will still be announced.
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed