Skip to content

Commit

Permalink
Timestamp Announce limitation (#3708)
Browse files Browse the repository at this point in the history
* Timestamp Announce limitation

* update changelog.md

* Update CHANGELOG.md

Co-authored-by: Corina <[email protected]>

* Update docs/ACCESSIBILITY.md

Co-authored-by: Corina <[email protected]>

* Update docs/ACCESSIBILITY.md

Co-authored-by: Corina <[email protected]>
  • Loading branch information
amkhalaf-github and corinagum authored Feb 9, 2021
1 parent 3c31f6b commit 9cea4cd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixes [#3411](https://github.com/microsoft/BotFramework-WebChat/issues/3411). With Direct Line Speech, clicking on microphone button during speech recognition should no longer stop working, by [@compulim](https://github.com/compulim) in PR [#3694](https://github.com/microsoft/BotFramework-WebChat/pull/3694)
- Although it no locker lock up microphone, clicking on the microphone button has no effect because Direct Line Speech does not support aborting speech recognition
- Fixes [#3421](https://github.com/microsoft/BotFramework-WebChat/issues/3421). With Direct Line Speech, after not able to recognize any speech, it should no longer stop working, by [@compulim](https://github.com/compulim) in PR [#3694](https://github.com/microsoft/BotFramework-WebChat/pull/3694)
- Fixes [#3616](https://github.com/microsoft/BotFramework-WebChat/issues/3616). [Accessibility documentation] Update activity timestamp grouping to match visual UI, by [@amal-khalaf](https://github.com/amal-khalaf) in PR [#3708](https://github.com/microsoft/BotFramework-WebChat/pull/3708)

### Changed

Expand Down
8 changes: 8 additions & 0 deletions docs/ACCESSIBILITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,14 @@ To make the live region more consistent across browsers and easier to control, w
- 0-100 ms: Chrome and TalkBack on Android may miss some of the activities
- The development team settled on using one second after some experimentation

### Technical Limitation

- Activity Time Stamp Announcement : Related to [#3136](https://github.com/microsoft/BotFramework-WebChat/issues/3136)
- Problem definition : Even when a user overrides the 'grouptimestamp' props and sets it to true or to some interval, AT still announces every activity with it's associated Time stamp.
- Explanation of current behavior : Once activity is marked as sent, it is written to DOM as well as it's Timestamp; the timestamp grouping logic is executed only when the next activity arrives. As mention earlier once a text is queued for narration and even if DOM element is removed it will still be announced by the screen reader as it is not technically possible to removed from the narration queue.
- Given above limitation even if we removed the timestamp element from DOM after group timestamp logic is executed this will not change the screen reader behavior.
- As per Accessibility team review/recommendation : There is no hiding or loss of information in this case - so will keep the current behavior as is.

## Do's and don't

### Do
Expand Down

0 comments on commit 9cea4cd

Please sign in to comment.