Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2608 Return focus to sendbox after clicking New Messages or Suggested Actions Button #2628

Merged
merged 3 commits into from
Nov 22, 2019
Merged

#2608 Return focus to sendbox after clicking New Messages or Suggested Actions Button #2628

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2177620
#2608 Return focus to sendbox after clicking New Messages or Suggeste…
corinagum Nov 21, 2019
135fe5e
Update CHANGELOG.md
corinagum Nov 21, 2019
f8f55cb
Fix test
corinagum Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/focus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ test('should not focus send box after clicking on send button', async () => {
});

// Verification of fix of #1971, https://github.com/microsoft/BotFramework-WebChat/issues/1971
test('should not focus send box after clicking on suggested actions', async () => {
test('SHOULD focus send box after clicking on suggested actions', async () => {
corinagum marked this conversation as resolved.
Show resolved Hide resolved
const { driver, pageObjects } = await setupWebDriver();

await driver.wait(uiConnected(), timeouts.directLine);
Expand All @@ -36,7 +36,7 @@ test('should not focus send box after clicking on suggested actions', async () =

await pageObjects.clickSuggestedActionButton(0);

await expect(sendBoxTextBoxFocused().fn(driver)).resolves.toBeFalsy();
await expect(sendBoxTextBoxFocused().fn(driver)).resolves.toBeTruthy();
});

// Verification of fix of #1971, https://github.com/microsoft/BotFramework-WebChat/issues/1971
Expand Down