Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2608 Return focus to sendbox after clicking New Messages or Suggested Actions Button #2628

Merged
merged 3 commits into from
Nov 22, 2019
Merged

#2608 Return focus to sendbox after clicking New Messages or Suggested Actions Button #2628

merged 3 commits into from
Nov 22, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Nov 21, 2019 •
edited
Loading

Fixes #2608

Changelog Entry

  • Fixes #2608. Focus will return to sendbox after clicking New Messages or a Suggested Actions button, by @corinagum in PR #2628

Description

This is an accessibility fix. Focus was 'disappearing' after clicking the New messages button. Now, the focus will return to the sendbox.

Specific Changes

  • Focus after clicking "New messages"
  • Focus after clicking a Suggested Action
  • Testing Added
    No tests, focus is hidden in our tests

tdurnford
tdurnford approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 64.082% when pulling f8f55cb on corinagum:2608-focus into b9fbe2e on microsoft:master.

@corinagum corinagum merged commit 3fe44cd into microsoft:master Nov 22, 2019
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@corinagum @coveralls @tdurnford