Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Arabic to localization #2369

Closed
wants to merge 6 commits into from
Closed

Adding Arabic to localization #2369

wants to merge 6 commits into from

Conversation

OdaiHatemMOE
Copy link

@OdaiHatemMOE OdaiHatemMOE commented Aug 29, 2019 •
edited
Loading

Fixes #

Changelog Entry

Adding Arabic localization

Description

Adding Arabic localization

Specific Changes

Adding ar-AR.js to localization

  • Testing Added

@msftclas
Copy link

msftclas commented Aug 29, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

corinagum
corinagum suggested changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the submission! I left a few comments, it would be great if you could address those. We would love to get this PR in. Thanks!

packages/component/src/Localization/ar-AR.js Show resolved Hide resolved
packages/component/src/Localization/ar-AR.js Show resolved Hide resolved
packages/component/src/Localization/ar-AR.js Show resolved Hide resolved
packages/component/src/Localization/ar-AR.js Outdated Show resolved Hide resolved
packages/component/src/Localization/ar-AR.js Outdated Show resolved Hide resolved
packages/component/src/Localization/ar-AR.js Outdated Show resolved Hide resolved
packages/component/src/Localization/ar-AR.js Show resolved Hide resolved
packages/component/src/Localization/ar-AR.js Outdated Show resolved Hide resolved
corinagum
corinagum approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@corinagum
Copy link
Contributor

It looks like the tests are failing because of linting errors. Could you run npm run eslint at the root of Web Chat and correct those errors? Please let me know if you have questions.

@corinagum
Copy link
Contributor

@OdaiHatemMOE gentle ping, would you be able to take a look at the linting errors? Thank you!

@corinagum corinagum mentioned this pull request Sep 11, 2019
Closed
@corinagum corinagum mentioned this pull request Oct 4, 2019
Closed
@corinagum
Copy link
Contributor

This PR is stale, so I am closing this issue. We will implement this in the future with original credit, and tracking can be found at #1976

@corinagum corinagum closed this Oct 4, 2019
@corinagum corinagum mentioned this pull request Oct 16, 2019
Closed
1 task
@corinagum corinagum mentioned this pull request Feb 7, 2020
Merged
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OdaiHatemMOE @msftclas @corinagum