Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IC3] Request: RTL support and localization for Hebrew, Urdu, and Arabic (+ info on localization contributions) #1976

Closed
Tamoormughal opened this issue May 10, 2019 · 10 comments · Fixed by #2890

Comments

@Tamoormughal
Copy link

Tamoormughal commented May 10, 2019

VSTS #1663019

[edited by @corinagum)

Feature request: RTL support for languages like Hebrew, Urdu, and Arabic, as well as localization support for Hindi and the previously listed languages.

[Question]
is it possible speech to text of google is implement in bot frame work V4 like hindi and urdu and arabic?

@Tamoormughal Tamoormughal added Pending question Further information is requested. Stack Overflow candidate labels May 10, 2019
@corinagum corinagum changed the title is it possible speech to text of google is implement in bot frame work V4 Request: RTL support and localization for Hebrew, Urdu, and Arabic (+ info on localization contributions) May 10, 2019
@corinagum
Copy link
Contributor

Hi @Tamoormughal, are you asking about adding localizations to V4 in Hindi, Urdu, and Arabic? (Please correct me if I am wrong), but I believe two of these languages would need RTL support, as well as the addition of the localized strings.
We have a PR already in existence, provided by the community, for which the review has been put on hold due to lack of bandwidth. #1548 If you have the time, it would be great if you could take a look at this PR and provide some feedback.

I am leaving this question as tracking for the RTL feature. If there are other Web Chat users interested in this feature, please leave your +1 comment here. :)

I believe Hindu does not need RTL support. If this is the case, providing localization will be a much simpler process. We welcome Pull Requests that add or modify the language files in ____. Please take a look at #1966 if you would like to look into the basics of creating a PR related to localization. You would be adding a new file to the BotFramework-WebChat/packages/component/src/Localization/ directory.

@corinagum corinagum added Enhancement front-burner and removed question Further information is requested. Stack Overflow candidate Pending labels May 10, 2019
@corinagum corinagum added backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed Triage-E labels May 17, 2019
@Kaiqb Kaiqb added the Customer label Jul 23, 2019
@corinagum
Copy link
Contributor

This also needs to involve discussion with Adaptive Cards :)

@sgellock sgellock removed the Customer label Aug 8, 2019
@corinagum
Copy link
Contributor

corinagum commented Oct 4, 2019

We have stale PRs related to Localization that haven't been completed yet due to scheduling problems. Those links are:
#2369
#1548
#2477

ALL contributions are very much appreciated! The dev team will implement these with original credit as one PR in the near future.

I am closing both above PRs, but any contributors are welcome to add to discussion here. For customers looking for these languages/RTL support, please chime in below.

@corinagum corinagum self-assigned this Oct 4, 2019
@geea-develop
Copy link
Contributor

@corinagum let me know if you need any assistance. we continuously merging the master to our fork but this takes time all because RTL is not natively supported. I don't think we are very far from it. Although adaptive cards will need some adjustments since they are not natively supported either.

@corinagum
Copy link
Contributor

@geea-develop I don't have a timeline for working on RTL support, but I hope that once I do I can consult with you! Thanks again for your contributions, and I apologize that this has taken a long time.

@corinagum corinagum added R8 and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Dec 10, 2019
@compulim compulim changed the title Request: RTL support and localization for Hebrew, Urdu, and Arabic (+ info on localization contributions) [IC3] Request: RTL support and localization for Hebrew, Urdu, and Arabic (+ info on localization contributions) Dec 18, 2019
@geea-develop
Copy link
Contributor

@corinagum hi, I see it has been added to todo for R8. let me know if you need me to assist as I don't see a pull request or work in process that has started.
thanks.

@corinagum
Copy link
Contributor

Thanks, will do!

@corinagum
Copy link
Contributor

corinagum commented Jan 8, 2020

@geea-develop for now, would you be able to provide your latest he-IL.js file? :)

Right now I'm using this: https://github.com/LeoChat/BotFramework-WebChat/blob/master/packages/component/src/Localization/he-IL.js

@geea-develop
Copy link
Contributor

https://gist.github.com/geea-develop/938f1a44267fb17164b41b7ecd2cfece

@Tamoormughal
Copy link
Author

Tamoormughal commented Jan 9, 2020 via email

@cwhitten cwhitten added the p0 Must Fix. Release-blocker label Jan 9, 2020
@corinagum corinagum added this to the R8 milestone Jan 15, 2020
@corinagum corinagum mentioned this issue Feb 7, 2020
52 tasks
@compulim compulim mentioned this issue Mar 5, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants