Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating submitSendBoxSaga.js to send sendBoxValue.trim() #2331

Merged
merged 10 commits into from
Aug 21, 2019
Merged

Updating submitSendBoxSaga.js to send sendBoxValue.trim() #2331

merged 10 commits into from
Aug 21, 2019

Conversation

jimmyjames177414
Copy link
Contributor

@jimmyjames177414 jimmyjames177414 commented Aug 16, 2019 •
edited
Loading

Suggested fix by @tdurnford for issue #2328
Sending questions with trailing spaces using enter fails to trim(). - fix included

Fixes #2328

Changelog Entry

Updating submitSendBoxSaga.js to send sendBoxValue.trim(), by @jimmyjames177414 in PR #2331

Description

Sending questions with trailing spaces using enter fails to trim(). - fix included

@jimmyjames177414
Updating submitSendBoxSaga.js
26a083b 
Suggested fix by tdurnford for issue microsoft#2330
Trimming sendBoxValue on enter key submit
@coveralls
Copy link

coveralls commented Aug 17, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 66.35% when pulling 511f30c on jimmyjames177414:patch-2 into 3e353ec on microsoft:master.

@tdurnford
Copy link
Contributor

@jimmyjames177414 Can you also update the CHANGELOG.md file? Thank you for your contribution!

@jimmyjames177414 jimmyjames177414 changed the title Updating submitSendBoxSaga.js Updating submitSendBoxSaga.js to send sendBoxValue.trim() Aug 19, 2019
@msftclas
Copy link

msftclas commented Aug 19, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@jimmyjames177414
Copy link
Contributor Author

Sounds great, I'll get right on it! Thank you for the opportunity!
It means the world to me.

corinagum
corinagum reviewed Aug 19, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jimmyjames177414
Updating CHANGELOG.md
2c12280 
Removing incorrect reference to minor patch in the CHANGELOG.md
@tdurnford
Copy link
Contributor

@jimmyjames177414 Can you also remove setSendBox(sendBoxValue.trim()) from the SendButton and TextBox?

@jimmyjames177414
Copy link
Contributor Author

@tdurnford yep! I'll get right on it!

jimmyjames177414 and others added 3 commits August 19, 2019 11:48
@jimmyjames177414
Removing redundancy in SendButton.js
9bfeb46 
Removing setSendBox(sendBoxValue.trim()) from SendButton.js
@jimmyjames177414
Removing redundancy in TextBox.js
81a92ea 
Removing setSendBox(sendBoxValue.trim()) from TextBox.js
@corinagum
Merge branch 'master' into patch-2
fc12956
tdurnford
tdurnford requested changes Aug 19, 2019
View reviewed changes
packages/component/src/SendBox/SendButton.js Outdated Show resolved Hide resolved
packages/component/src/SendBox/SendButton.js Outdated Show resolved Hide resolved
corinagum and others added 2 commits August 19, 2019 11:05
@corinagum
Merge branch 'master' into patch-2
deed7b9
@jimmyjames177414
Refactoring SendButton.js
0474d1c 
Implementing @tdurnford's refactoring request for SendButton.js:
-Removing setSendBox and sendBoxValue from function declaration since it is no longer used.
-Since we are only making one function call in the click method, we are removing it and passing submitSendBox to the button's onClick handler.
@corinagum
Copy link
Contributor

@jimmyjames177414, thanks for your hard work so far. :) Just FYI, the CI is failing because there are linting errors. you can run the command npm run eslint in your console and see below:
image

Once these are fixed we can see if any tests are failing. Let us know if you have questions.

@jimmyjames177414
Correcting Lint errors in SendButton.js
511f30c 
Correcting Lint errors in SendButton.js
@tdurnford
Copy link
Contributor

tdurnford commented Aug 21, 2019 •
edited
Loading

Looks good to me! Thanks again for your help @jimmyjames177414! The Web Chat team really appreciates your contributions. If you are interested in contributing more, I highly recommend you take a look at our issues labeled "Help wanted" and "Good first bug".

@tdurnford tdurnford merged commit cb39597 into microsoft:master Aug 21, 2019
@jimmyjames177414
Copy link
Contributor Author

Woo hoo!
Thanks for all your patience and guidance with this pull request process!
I will definitely look into the "Help wanted" and "Good first bug" sections as soon as I get a chance.

@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
compulim added a commit to compulim/BotFramework-WebChat that referenced this pull request Oct 26, 2019
@compulim
Add test for microsoft#2331
f2eef80
@compulim compulim mentioned this pull request Oct 28, 2019
Merged
1 task
corinagum pushed a commit that referenced this pull request Oct 29, 2019
@compulim @corinagum
Add tests for #2331, #2332, and #2399 (#2504)
aaadb89 
* Add test for #2331

* Add test for hiding scroll to bottom button

* Add test for YouTube full screen control

* Reliability

* Filter out DIRECT_LINE/CONNECT* actions

* Set payload.directLine to empty object

* Filter out payload.directLine

* Better filtering
@spyip spyip mentioned this pull request Nov 6, 2019
Merged
1 task
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum left review comments

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending questions with trailing spaces using enter fails to trim(). - fix included
5 participants
@jimmyjames177414 @coveralls @tdurnford @msftclas @corinagum