Trimming sendBoxValue on enter key submit: issue 2328 #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix for "Sending questions with trailing spaces using enter fails to trim(). - fix included microsoft#2328" microsoft#2328
jimmyjames177414
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
jimmyjames177414
changed the title
|
incorrect assumption |
jimmyjames177414
added a commit
to jimmyjames177414/BotFramework-WebChat
that referenced
this pull request
Aug 16, 2019
Suggested fix by tdurnford for issue microsoft#2330 Trimming sendBoxValue on enter key submit
tdurnford
pushed a commit
that referenced
this pull request
Aug 21, 2019
* Updating submitSendBoxSaga.js Suggested fix by tdurnford for issue #2330 Trimming sendBoxValue on enter key submit * Updating CHANGELOG.md * Updating CHANGELOG.md Removing incorrect reference to minor patch in the CHANGELOG.md * Removing redundancy in SendButton.js Removing setSendBox(sendBoxValue.trim()) from SendButton.js * Removing redundancy in TextBox.js Removing setSendBox(sendBoxValue.trim()) from TextBox.js * Refactoring SendButton.js Implementing @tdurnford's refactoring request for SendButton.js: -Removing setSendBox and sendBoxValue from function declaration since it is no longer used. -Since we are only making one function call in the click method, we are removing it and passing submitSendBox to the button's onClick handler. * Correcting Lint errors in SendButton.js Correcting Lint errors in SendButton.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for "Sending questions with trailing spaces using enter fails to trim(). - fix included #2328"
#2328
Fixes #2328
Changelog Entry
Description
Added .trim() to submissions or questions via the enter key
file: BotFramework-WebChat/packages/component/src/SendBox/TextBox.js
Line 34 needs to be added to the red if condition shown below: