-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility on focus management and disable Adaptive Cards #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
May 11, 2020 18:28
compulim
commented
May 21, 2020
tdurnford
reviewed
May 28, 2020
tdurnford
reviewed
May 28, 2020
tdurnford
reviewed
May 28, 2020
tdurnford
reviewed
May 28, 2020
tdurnford
reviewed
May 28, 2020
tdurnford
reviewed
May 28, 2020
tdurnford
reviewed
May 28, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
tdurnford
reviewed
May 29, 2020
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
This was referenced Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
disabled
prop and addedactionPerformedClassName
in Adaptive Card and other legacy cards, by @compulim in PR #3150Fixed
Changed
component
[email protected]
[email protected]
Samples
Description
This will provide a better accessibility and UX for answering prompts via Adaptive Card and other cards.
Fixed accessibility around focus management on the "New messages" button and how UIs are disabled.
Specific Changes
Accessibility for disabled elements
Disabled elements will have the focus retained on them temporarily. When the user focus to another element, the disabled element will have
disabled
attribute set, thus they will not be able to TAB back once TAB out.Excerpt from code comment
Differences between
<button>
and<AccessibleButton>
:aria-disabled
attribute totrue
readonly
attributedisabled
attribute, until it is blurreddisabled
attributeonClick
handlerDevelopers using this accessible widget will need to:
:disabled, [aria-disabled="true"] {}
disabled
attribute to usearia-disabled="true"
insteadaria-disabled="true"
is the source of truth<form>
, the developer need to filter out someonSubmit
event caused by this widgetCorrect tab order for "New messages" button
"New messages" button is appended after the last read activity, but not last shown activity. I.e. this make the button TAB-able.
Additional context
[email protected]
->@2.1.0
[email protected]
->@2.0.0