feat: Added dialog schema editor to the Adaptive Dialog Property Editor #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
tdurnford
commented
Jun 18, 2020
Composer/packages/ui-plugins/schema-editor/src/AdaptiveDialogField.tsx
Outdated
Show resolved
Hide resolved
beyackle
reviewed
Jun 18, 2020
Composer/packages/client/src/store/persistence/FilePersistence.ts
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
reviewed
Jun 19, 2020
Composer/packages/ui-plugins/schema-editor/src/AdaptiveDialogField.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
reviewed
Jun 22, 2020
|
Marking as draft until UX is finalized. |
|
@tdurnford - which stage in the design is represented by the dialog shown above? |
|
@mareekuh The dialog schema editor falls more in line with the 'Create skill from bot' stage; however, it is specific to each dialog, and I don't believe its application is limited to skills. |
cwhitten
reviewed
Aug 4, 2020
| @@ -8,112 +8,6 @@ export const BASEURL = `${process.env.PUBLIC_URL || ''}/api`; | |||
|
|
|||
| //the count about the undo/redo | |||
| export const UNDO_LIMIT = 10; | |||
| /** | |||
There was a problem hiding this comment.
@srinaath asked if I could remove the actions in my PR. They should have been moved in removed with the recoil changes.
There was a problem hiding this comment.
Yep. Those constants are no longer required. They were part of the React context action reducer model that we used to have.
cwhitten
approved these changes
Aug 5, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…or (microsoft#3436) * feat: Added dialog schema editor * renamed function * clean up * fixed typo * minor fix * Add support for deleting dialog schema files * fix lint issues * split into multiple ediotrs * fixed property * Reset state * Dialog schema editor * Recoil changes * Removed ActionTypes enum * Bot structure changes * Recoil tests * lint * File Persistence tests * Adaptive form * Merge fixes * object utils * fix tests * lint * remove definitions of change * Object util types * object util tests * Added collapse * types * Collapse * type * lint * definitions * lint * tests * title * fixed test * tests Co-authored-by: Ben Yackley <[email protected]> Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a dialog schema editor ui-plugin that adds a 'Dialog Schema' field to the Adaptive Dialog Property Editor. Users can use the field to edit
*.dialog.schemafiles which serialize to the dialog's directory on disk.Task Item
Closes #3435
Screenshots