Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill Manifest experience under par #3380

Closed
cxbuilders opened this issue Jun 11, 2020 · 7 comments · Fixed by #3835
Closed

Skill Manifest experience under par #3380

cxbuilders opened this issue Jun 11, 2020 · 7 comments · Fixed by #3835
Assignees
Labels
UX Design Need UX Design

Comments

@cxbuilders
Copy link

cxbuilders commented Jun 11, 2020

The whole setup of the skill manifest editor feels like it is lacking behind the rest quite a bit. Below my thoughts on this:

Export as skill
Having it under the export dropdown and calling it export as skill sounds strange to me. You're actually not exporting anything, you're just creating a manifest which makes it a skill. So I would just expect it to be called something like "edit skill manifests"

Naming of Manifests
The naming of the manifests are fixed to {Botname}{schema version}.json
This makes no sense to me, why is the schema version part of the filename? Also having the botname in the filename seems not needed, as the url of the manifest will contain the botname, so it only gets unnecessarily complicated. To me the best way of doing this would be to use the actual version of the manifest itself like so: manifest-v1.0.json
image

Editing Manifests
It should be possible to manage multiple manifests to allow for different versions. Currently when creating a new one it just overwrites whatever is there..

@cxbuilders cxbuilders added the Needs-triage A new issue that require triage label Jun 11, 2020
@hibrenda
Copy link
Contributor

Hi @cxbuilders thanks for the feedback. This is on our radar. we have several issues tracking skill manifest experience. @mareekuh for your awareness.

@hibrenda hibrenda added UX Design Need UX Design Type: Enhancement and removed Needs-triage A new issue that require triage labels Jun 15, 2020
@mareekuh
Copy link
Contributor

Yup, thank you. A more user friendly experience is spec'ed and in the works.
Groetjes,
Marieke

@cxbuilders
Copy link
Author

cxbuilders commented Jun 29, 2020

@mareekuh Helemaal goed!

Thanks,
Bastiaan

@sgellock
Copy link
Member

sgellock commented Jul 2, 2020

@hibrenda can you provide links to issues so this customer can track our progress and see what work is on the books? thank you

@hibrenda
Copy link
Contributor

hibrenda commented Jul 3, 2020

@sgellock Sure. attached the issues #3355
and related pr #3436

@mareekuh
Copy link
Contributor

mareekuh commented Jul 7, 2020

  • Export as skill -> Add another toolbar item: Create manifest and Leave the 'Export as skill'. See design here
  • Naming of Manifests -> Fair request. Is there a reason why the name is not editable? If not, let's add a default name (structured as currently spec'ed) but allow people to change it. @tdurnford
  • Editing Manifests -> seems reasonable - @cxbuilders : what is the scenario in which one wants to generate multiple manifests and wants to keep them all? Replacing the existing manifest keeps things simple and tidy (no need to add other UI/functionality to have people manage multiple manifests).

@mareekuh mareekuh assigned mareekuh, cwhitten and tdurnford and unassigned mareekuh Jul 7, 2020
@cxbuilders
Copy link
Author

cxbuilders commented Jul 7, 2020

@mareekuh Keeping multiple versions was my initial quick thinking about about versioning the bot, however the bot itself represents 1 version, so 1 manifest would do. So I agree you can skip this requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Design Need UX Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants