[Samples][Java] Fix disparities of 03.welcome-user sample #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batta32
requested review from
sgellock and
peterinnesmsft
and removed request for
a team
|
Hi @tracyboehrer & @LeeParrishMSFT, we created this PR fixing some disparities that we found in the |
tracyboehrer
approved these changes
Apr 27, 2021
tracyboehrer
added a commit
that referenced
this pull request
Apr 28, 2021
* Moving Samples from Java Repo to Samples Repo (#3163) * Initial move of samples to Samples Repo * Add generators to Samples Repo * Java: Added support to support using snapshots (#3164) * [Samples] Add 42.scaleout sample (#3165) * Add scaleout as module in samples folder * Add documents * Add resources folder * Add webapp folder * Add empty test * Add Bot class * Add Dialog class * Add Storages * Add Adapter * Add Accessor * Add DialogHost class * Add Startup class * Add package-info file * Add pom.xml * Added .gitignore file (#3178) * [Samples][Java] Fix disparities of 16.proactive-messages sample (#3193) * Update README - Add Interacting with the bot section - Remove broken link - Remove duplicated link * Fix bot name in Index.html * Update ProactiveBot - Add missing comments - Update message to match C# - Update property * Fix mandatory app password issue * Remove untracked files * Update welcomeMessage variable * Add package-info.java * Update README * Remove target folder Co-authored-by: Victor <[email protected]> * [Samples][Java] Fix disparities of 02.echo-bot sample (#3195) * Update readme * Add SSML * Add package-info.java * Remove temporal files * Update readme Co-authored-by: Victor <[email protected]> * Update to release version. (#3197) * Java: Udpatged generator version * [Samples][Java] Fix disparities of 05.multi-turn-prompt sample (#3203) * Remove temporal files * Update README.md * Add package-info.java * Update index.html * Add missing comment * Update DialogBot.java * Update UserProfileDialog.java * Add logger * Apply nit changes Co-authored-by: Victor <[email protected]> * [Samples][Java] Fix disparities of 03.welcome-user sample (#3198) * Add changes / fixes for bot 3.welcome-user * Fix code changes * Add corrections in readme Co-authored-by: matiasroldan6 <[email protected]> * [Samples][Java] Fix disparities of 06.using-cards sample (#3207) * Add sample 6 fixes * Requested changes in README * Remove settings folder Co-authored-by: matiasroldan6 <[email protected]> Co-authored-by: tracyboehrer <[email protected]> Co-authored-by: Martin Battaglino <[email protected]> Co-authored-by: Victor <[email protected]> Co-authored-by: matiasroldan6 <[email protected]>
matiasroldan6
added a commit
to southworks/BotBuilder-Samples
that referenced
this pull request
Apr 29, 2021
…3198) * Add changes / fixes for bot 3.welcome-user * Fix code changes * Add corrections in readme Co-authored-by: matiasroldan6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to microsoft/botbuilder-java#1165
Proposed Changes
We compared the documentation/code migration/behavior of the
03.welcome-usersample between Java and C# and we found disparities and fixes that this PR includes.WelcomeUserBotthat are sent just like C#target/.classpath)package-info.javafileTesting
Welcome user sample working as expected
