Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples] Add 42.scaleout sample #3165

Conversation

Batta32
Copy link
Contributor

@Batta32 Batta32 commented Apr 13, 2021

Fixes microsoft/botbuilder-java#876

Description

We are adding the sample 42.scaleout in Java taking into account the C# 42.scaleout present in BotBuilder-Samples repository.

Specific Changes

  • Generate main structure of the sample
  • Add root files
  • Add README/LICENSE documents
  • Add scaleout sample as module in samples folder

Testing

Current behavior of the Java migrated sample
image

BlobStore written during the communication with the Java migrated sample
image

mvn package of the Java migrated sample
image

@Batta32 Batta32 requested a review from a team as a code owner April 13, 2021 18:19
@Batta32 Batta32 requested review from axelsrz and EricDahlvang and removed request for a team April 13, 2021 18:19
@Batta32
Copy link
Contributor Author

Batta32 commented Apr 13, 2021

@tracyboehrer & @LeeParrishMSFT we created this PR which includes the sample 42.scaleout in order to be merged in the Java-R13 branch 😊.

@LeeParrishMSFT LeeParrishMSFT self-requested a review April 14, 2021 16:57
@LeeParrishMSFT LeeParrishMSFT merged commit 6670ff6 into microsoft:Java-R13 Apr 14, 2021
@Batta32 Batta32 deleted the external/feature/southworks/samples/scaleout/base branch April 14, 2021 17:07
tracyboehrer added a commit that referenced this pull request Apr 28, 2021
* Moving Samples from Java Repo to Samples Repo (#3163)

* Initial move of samples to Samples Repo

* Add generators to Samples Repo

* Java: Added support to support using snapshots (#3164)

* [Samples] Add 42.scaleout sample (#3165)

* Add scaleout as module in samples folder

* Add documents

* Add resources folder

* Add webapp folder

* Add empty test

* Add Bot class

* Add Dialog class

* Add Storages

* Add Adapter

* Add Accessor

* Add DialogHost class

* Add Startup class

* Add package-info file

* Add pom.xml

* Added .gitignore file (#3178)

* [Samples][Java] Fix disparities of 16.proactive-messages sample (#3193)

* Update README

- Add Interacting with the bot section
- Remove broken link
- Remove duplicated link

* Fix bot name in Index.html

* Update ProactiveBot

- Add missing comments
- Update message to match C#
- Update property

* Fix mandatory app password issue

* Remove untracked files

* Update welcomeMessage variable

* Add package-info.java

* Update README

* Remove target folder

Co-authored-by: Victor <[email protected]>

* [Samples][Java] Fix disparities of 02.echo-bot sample (#3195)

* Update readme

* Add SSML

* Add package-info.java

* Remove temporal files

* Update readme

Co-authored-by: Victor <[email protected]>

* Update to release version. (#3197)

* Java: Udpatged generator version

* [Samples][Java] Fix disparities of 05.multi-turn-prompt sample (#3203)

* Remove temporal files

* Update README.md

* Add package-info.java

* Update index.html

* Add missing comment

* Update DialogBot.java

* Update UserProfileDialog.java

* Add logger

* Apply nit changes

Co-authored-by: Victor <[email protected]>

* [Samples][Java] Fix disparities of 03.welcome-user sample (#3198)

* Add changes / fixes for bot 3.welcome-user

* Fix code changes

* Add corrections in readme

Co-authored-by: matiasroldan6 <[email protected]>

* [Samples][Java] Fix disparities of 06.using-cards sample (#3207)

* Add sample 6 fixes

* Requested changes in README

* Remove settings folder

Co-authored-by: matiasroldan6 <[email protected]>

Co-authored-by: tracyboehrer <[email protected]>
Co-authored-by: Martin Battaglino <[email protected]>
Co-authored-by: Victor <[email protected]>
Co-authored-by: matiasroldan6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants