SDk connection string 3 #1224
Merged
SDk connection string 3 #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
force-pushed
the
tilee/connectionString3
branch
from
6619574
to
324a1e0
Compare
cijothomas
reviewed
Sep 26, 2019
| @@ -269,7 +269,7 @@ public IApplicationIdProvider ApplicationIdProvider | |||
| public EndpointContainer EndpointContainer { get; private set; } = new EndpointContainer(new EndpointProvider()); | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets the connection string. Setting this value will also set the Instrumentation Key, validate the endpoints, and set the TelemetryChannel.Endpoint. | |||
| /// Gets or sets the connection string. Setting this value will also set (and overwrite) the Instrumentation Key. The endpoints are validated and will be set (and overwrite) our first party TelemetryChannels as well as the ApplicationIdProvider. | |||
There was a problem hiding this comment.
will be set (and overwrite) our first party TelemetryChannels -> will be set (and overwritten) for InMemoryChannel and ServerTelemetryChannel
cijothomas
reviewed
Sep 26, 2019
| @@ -269,7 +269,7 @@ public IApplicationIdProvider ApplicationIdProvider | |||
| public EndpointContainer EndpointContainer { get; private set; } = new EndpointContainer(new EndpointProvider()); | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets the connection string. Setting this value will also set the Instrumentation Key, validate the endpoints, and set the TelemetryChannel.Endpoint. | |||
| /// Gets or sets the connection string. Setting this value will also set (and overwrite) the Instrumentation Key. The endpoints are validated and will be set (and overwrite) our first party TelemetryChannels as well as the ApplicationIdProvider. | |||
There was a problem hiding this comment.
Instrumentation Key -> InstrumentationKey(link to actual field if possible)
cijothomas
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1221
update comments