Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDk connection string 3 #1224

Merged
merged 2 commits into from
Sep 27, 2019
Merged

SDk connection string 3 #1224

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324a1e0
update comments
TimothyMothra Sep 26, 2019
7f1fce8
update
TimothyMothra Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ public IApplicationIdProvider ApplicationIdProvider
public EndpointContainer EndpointContainer { get; private set; } = new EndpointContainer(new EndpointProvider());

/// <summary>
/// Gets or sets the connection string. Setting this value will also set the Instrumentation Key, validate the endpoints, and set the TelemetryChannel.Endpoint.
/// Gets or sets the connection string. Setting this value will also set (and overwrite) the Instrumentation Key. The endpoints are validated and will be set (and overwrite) our first party TelemetryChannels as well as the ApplicationIdProvider.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be set (and overwrite) our first party TelemetryChannels -> will be set (and overwritten) for InMemoryChannel and ServerTelemetryChannel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instrumentation Key -> InstrumentationKey(link to actual field if possible)

/// </summary>
public string ConnectionString
{
Expand Down Expand Up @@ -300,7 +300,6 @@ public string ConnectionString
}

// UPDATE APPLICATION ID PROVIDER
// NOTE: This can be removed when the Indexer Service goes live sometime in 2020.
SetApplicationIdEndpoint(this.ApplicationIdProvider, this.EndpointContainer.FormattedApplicationIdEndpoint);
}
catch (Exception ex)
Expand Down