-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile BaseIntermediateOutputPath handling between -dotnet and -dotnet-logging repos #490
Comments
I'll take a look at this. I like the idea of keeping the standard project file structure. |
Super, thanks a bunch @pharring ! |
Rename Global.props to Directory.Build.props so it will automatically be included in every project.
Fix #490 by using Directory.Build.props
This is fixed now, but I had to workaround an issue with gitlink (it insists on using MSBuild 4.0 tools). I notice that gitlink 3.0.0 has moved to a model where it is integrated with the build (.props and .targets) instead of just calling out to an EXE. That version is in preview but we could switch to it when it is stable and remove the workaround.. |
This repo and the -dotnet-logging repo are using a different solution to the problem described in dotnet/msbuild#1603 (comment)
This repo manually ensures that BaseIntermediateOutputPath is set before Microsoft.Common.props is loaded. The -dotnet-logging repo is using a Directory.Build.props file (technically, will be using this file when microsoft/ApplicationInsights-dotnet-logging#77 is merged)
We should make it consistent between the two repos. My (karolz) slight preference would be to use Directory.Build.props as it allows the project file to use the standard structure.
The text was updated successfully, but these errors were encountered: