Schema says that Version property isn't required #2958
Assignees
Labels
Comments
|
Ah maybe it's an artifact of version not being required within Action.ShowCard? And that's not able to be represented in the schema file? The description could at least be updated to say at the beginning, |
paulcam206
added a commit
that referenced
this issue
May 24, 2019
Make description for version attribute a little more clear about being required for toplevel cards. Fixes #2958
|
this will be covered as part of my documentation changes |
andrewleader
added a commit
that referenced
this issue
Jun 7, 2019
* Create Image.md * Update Image.md * Update Image.md * More specs * Media element * Trying to get auto generate working * Closer! * [Schema] Document data URI Feature spec #628 * [Schema] Introduce inlineAction Original spec #147 * Specs auto-generated! * [Schema] Add ActionSet Spec #877 * Include marked-schema locally * Improve formatting of markdown table * [Schema] Update version description Make description for version attribute a little more clear about being required for toplevel cards. Fixes #2958 * [Schema] Add fontType to TextBlock Spec #1078 * [Schema] Add wrap to ChoiceSet and Toggle Spec #1887 * Move spec generation to separate module * Standalone spec generator script * Auto-update specs on save * Add some readme's * Spec updating readme * Point people to the readme * 1.2 features * Move Adaptive Card rendering into the actual spec file * Started adding action specs * Generate host config * More action info * More ActionSet details * Mock renderer statuses * Finished with actions * Columns * Start adding backgroundImage * Started working on schema-with-types * Testing infrastructure * Add URI support * Add required support * Refactor to class * Add type references * Add extending classes * Add inehritance with referencing base class * Support multiple types for single property * Add arrays * Add tests for arrays of base types * Add dictionary support * Generate typed schema schema from typed schema itself * Add typed schema schema * Add booleans * Disallow additional properties * Add extends and schema to json schema * Started updating some of the schema * Support multiple top-level types and other fixes * Fix not being able to add properties to extended classes * Add ability to change property name of type property * Support having a default type that doesn't need type specified * New classType schema * Add ContainerStyle enum * Add VerticalContentAlignment * Support default and required in schema * Support any object type * Update schemas * Add nullable * Add any arrays * Update schemas * Add shorthands * Start writing more schema * Allow type to not be specified at top level * Infer type names from file name * Add more schema * Add marker interfaces * More elements * Support recursive directories * Rename to typed-schema * Report more useful errors * Start generating Adaptive Card schema * Support enums * Schema starting to work! * Fix incorrect container property * Fix extended classes not allowing extended properties * Rename to src folder * Adding columns * Closer to multiple tiers of extending * Support multiple inheritance * Throw errors on unknown types * Rename to BlockElement * Add FactSet * Add ImageSet * Add Input.Text * Added all inputs * Add typed classes for the parser * Create overall Schema type object * Support loading schema from folder * Almost got spec generation working with new format! * Add ActionSet * Markdown generation is getting there! * Markdown generation almost done * Generate enum specs * Add enum value description support * Add shorthand property to classes * Update schema to support shorthand * Update schema file * Include lib * Updated schema * Add RichTextBlock * Re-organize * Change image uris to strings for relative urls * Add Style property to Card * Add Action.ToggleVisibility * Add style to actions * Remove duplicative BlockElement properties * Add fallback * Update wrap property on inputs * Generated * Update Input.Text selectAction * Generate * Add some versions * Fix blank allOf * Added a test that tests our samples * Add horizontalAlignment to richtextblock * Add minHeight * Add minHeight to AdaptiveCard * Add isVisible * Update package-lock.json * Add verticalContentAlignment to Adaptive Card * Add height to container and columnset * Add height to Column * Add height to all elements * Support overriding properties * Fix image height property * Fix overriding of inherited properties * Update adaptive-card-new.json * Make Column.items not required * All samples valid * Use uri-reference * Support allowAdditionalProperties * Allow custom enums * card.style version = 1.2 * Include build-model * Correctly display version number in markdown * Support shorthands in markdown and fix background image version * Remove generate-specs from website * Generating site from new schema partially working * Site generating properties * Fix schema literals in website properties * Make inherited detailed properties appear, and fix examples for properties * Make type appear correctly on markdown tables * Update toc * Add new elements * Re-order version property * Show type type in type * Support displaying enum value versions * Style the default value correctly * Indicate that type on inlines is required * Support inline shorthand * Improve image size documentation * Fix inlineAction description * Surface required properties at top of table * Remove local marked-schema * Rename BlockElement to Element * Dispaly uri-reference as uri * Rename fonttype sample * Add expense report example * Update schema file in sample * Update ExpenseReport to use Submit * Support case insensitive enums * Remove generated adaptive card schema * Make release build schema * Remove compiled typed-script schema * Add instruction for generating Adaptive schema * Remove spec-generator * Update samples schema test to use correct payload * Remove specs * Support multiple schema versions * UWP test updates for renamed FontType test * Typo in UWP test app * Update UWP tests after sample payloads changed * Add FontType expected tests * Add readme for schema * Update Visualizer to reference new schema file and all samples * Fix iOS referencing old FontTypes payload
|
Fixed in master with our 1.2 updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The schema says that version isn't required, yet as far as I'm aware it's certainly required
Paul, maybe you can fix this as part of the 1.2 updates?
The text was updated successfully, but these errors were encountered: