Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce wrap property on ChoiceSet/Toggle #1887

Closed
6 tasks done
dclaux opened this issue Sep 11, 2018 · 7 comments
Closed
6 tasks done

Introduce wrap property on ChoiceSet/Toggle #1887

dclaux opened this issue Sep 11, 2018 · 7 comments

Comments

@dclaux
Copy link
Member

dclaux commented Sep 11, 2018

Release Renderer status Tasks status
1.2 ✔️ .NET (#2219)
✔️ Android (#2218)
✔️ iOS (#2216)
✔️ TS (#2423)
✔️ UWP (#2217)
✔️ Shared (#2215)

Solves requests

Summary

Allow the authors to specify if they want their title to wrap. We could either:

  1. Change the current behavior and always wrap. The risk here is to degrade the experience for some existing scenarios
  2. Provide a setting in HostConfig to control title wrapping. This would allow hosts to opt into title wrapping
  3. Allow card authors to decide

I recommend option 3, with the default being "no wrap" to maintain compatibility with the current behavior.

Example

Add a wrap property to Input.Toggle:

{
    "type": "Input.Toggle",
    "title": "This is a very long title",
    "wrap": true
}

Add a wrap property to Input.ChoiceSet:

{
    "type": "Input.ChoiceSet",
    "choices": [
        { "title": "This choice has a very long title", "value": "1" },
        { "title": "This is another choice", "value": "2" }
    ],
    "wrap": true
}

Host Config

No changes.

Down-level impact

Low. Content simply won't wrap, but it never did anyways.

Host burden

None. All handled by the renderer.

Renderer Requirements

  1. A renderer should respect the wrap property and display accordingly.

Auto-generated task status

  • Shared
  • .NET
  • Android
  • iOS
  • TS
  • UWP
@dkonyayev
Copy link

I also need this feature. Any ETA?

@khouzam
Copy link

khouzam commented Sep 26, 2018

This will most likely be part of our 1.2 release. No firm date on it though.

@andrewleader andrewleader changed the title Ability to wrap the title of radio buttons and check boxes Proposal: Introduce wrap property on ChoiceSet/Toggle Oct 1, 2018
@andrewleader andrewleader changed the title Proposal: Introduce wrap property on ChoiceSet/Toggle Spec draft: Introduce wrap property on ChoiceSet/Toggle Oct 3, 2018
@andrewleader
Copy link
Contributor

Proposal approved. Note that we also liked the proposal for adding a content property to ChoiceSet/Toggle, but for simplicity purposes, being able to easily control the text wrapping is desirable, so we also want this proposal.

@Shon-Elias
Copy link

Got an ETA for that?

@andrewleader
Copy link
Contributor

@Shon-Elias this will most likely be part of our 1.2 release. We don't have a release date to share yet, 1.1 was just released two months ago.

paulcam206 added a commit that referenced this issue May 24, 2019
andrewleader added a commit that referenced this issue Jun 7, 2019
* Create Image.md

* Update Image.md

* Update Image.md

* More specs

* Media element

* Trying to get auto generate working

* Closer!

* [Schema] Document data URI

Feature spec #628

* [Schema] Introduce inlineAction

Original spec #147

* Specs auto-generated!

* [Schema] Add ActionSet

Spec #877

* Include marked-schema locally

* Improve formatting of markdown table

* [Schema] Update version description

Make description for version attribute a little more clear about being required for toplevel cards.

Fixes #2958

* [Schema] Add fontType to TextBlock

Spec #1078

* [Schema] Add wrap to ChoiceSet and Toggle

Spec #1887

* Move spec generation to separate module

* Standalone spec generator script

* Auto-update specs on save

* Add some readme's

* Spec updating readme

* Point people to the readme

* 1.2 features

* Move Adaptive Card rendering into the actual spec file

* Started adding action specs

* Generate host config

* More action info

* More ActionSet details

* Mock renderer statuses

* Finished with actions

* Columns

* Start adding backgroundImage

* Started working on schema-with-types

* Testing infrastructure

* Add URI support

* Add required support

* Refactor to class

* Add type references

* Add extending classes

* Add inehritance with referencing base class

* Support multiple types for single property

* Add arrays

* Add tests for arrays of base types

* Add dictionary support

* Generate typed schema schema from typed schema itself

* Add typed schema schema

* Add booleans

* Disallow additional properties

* Add extends and schema to json schema

* Started updating some of the schema

* Support multiple top-level types and other fixes

* Fix not being able to add properties to extended classes

* Add ability to change property name of type property

* Support having a default type that doesn't need type specified

* New classType schema

* Add ContainerStyle enum

* Add VerticalContentAlignment

* Support default and required in schema

* Support any object type

* Update schemas

* Add nullable

* Add any arrays

* Update schemas

* Add shorthands

* Start writing more schema

* Allow type to not be specified at top level

* Infer type names from file name

* Add more schema

* Add marker interfaces

* More elements

* Support recursive directories

* Rename to typed-schema

* Report more useful errors

* Start generating Adaptive Card schema

* Support enums

* Schema starting to work!

* Fix incorrect container property

* Fix extended classes not allowing extended properties

* Rename to src folder

* Adding columns

* Closer to multiple tiers of extending

* Support multiple inheritance

* Throw errors on unknown types

* Rename to BlockElement

* Add FactSet

* Add ImageSet

* Add Input.Text

* Added all inputs

* Add typed classes for the parser

* Create overall Schema type object

* Support loading schema from folder

* Almost got spec generation working with new format!

* Add ActionSet

* Markdown generation is getting there!

* Markdown generation almost done

* Generate enum specs

* Add enum value description support

* Add shorthand property to classes

* Update schema to support shorthand

* Update schema file

* Include lib

* Updated schema

* Add RichTextBlock

* Re-organize

* Change image uris to strings for relative urls

* Add Style property to Card

* Add Action.ToggleVisibility

* Add style to actions

* Remove duplicative BlockElement properties

* Add fallback

* Update wrap property on inputs

* Generated

* Update Input.Text selectAction

* Generate

* Add some versions

* Fix blank allOf

* Added a test that tests our samples

* Add horizontalAlignment to richtextblock

* Add minHeight

* Add minHeight to AdaptiveCard

* Add isVisible

* Update package-lock.json

* Add verticalContentAlignment to Adaptive Card

* Add height to container and columnset

* Add height to Column

* Add height to all elements

* Support overriding properties

* Fix image height property

* Fix overriding of inherited properties

* Update adaptive-card-new.json

* Make Column.items not required

* All samples valid

* Use uri-reference

* Support allowAdditionalProperties

* Allow custom enums

* card.style version = 1.2

* Include build-model

* Correctly display version number in markdown

* Support shorthands in markdown and fix background image version

* Remove generate-specs from website

* Generating site from new schema partially working

* Site generating properties

* Fix schema literals in website properties

* Make inherited detailed properties appear, and fix examples for properties

* Make type appear correctly on markdown tables

* Update toc

* Add new elements

* Re-order version property

* Show type type in type

* Support displaying enum value versions

* Style the default value correctly

* Indicate that type on inlines is required

* Support inline shorthand

* Improve image size documentation

* Fix inlineAction description

* Surface required properties at top of table

* Remove local marked-schema

* Rename BlockElement to Element

* Dispaly uri-reference as uri

* Rename fonttype sample

* Add expense report example

* Update schema file in sample

* Update ExpenseReport to use Submit

* Support case insensitive enums

* Remove generated adaptive card schema

* Make release build schema

* Remove compiled typed-script schema

* Add instruction for generating Adaptive schema

* Remove spec-generator

* Update samples schema test to use correct payload

* Remove specs

* Support multiple schema versions

* UWP test updates for renamed FontType test

* Typo in UWP test app

* Update UWP tests after sample payloads changed

* Add FontType expected tests

* Add readme for schema

* Update Visualizer to reference new schema file and all samples

* Fix iOS referencing old FontTypes payload
@Shon-Elias
Copy link

Version 1.2 was released but it does not support most of the channels.

I would like to use this feature for MS Teams but at the moment you are supporting only version 1.0.

Why is it take that long to support that feature? when will it be available for MS Teams users?

@andrewleader
Copy link
Contributor

Microsoft Teams is working on updating to 1.2. You can send your feedback to them using their UserVoice: https://microsoftteams.uservoice.com/forums/555103-public

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants