bug: props with optional getters should be validated #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in 3.x a class with optional getters was still validated. This reproducer tests this case, and shows that it currently fails to validate. This was discovered in building the hibernate-reactive guide where we have the following validated DTO: https://github.com/micronaut-projects/micronaut-guides/blob/ab0bfb2c117de73b24aabbb9422ec58dadaebb8d/guides/micronaut-hibernate-reactive/java/src/main/java/example/micronaut/SortingAndOrderArguments.java
|
This seems related to #114 and micronaut-projects/micronaut-core#9203 |
|
@timyates lets annotate this with |
|
sdelamo
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in 3.x a class with optional getters was still validated.
This reproducer tests this case, and shows that it currently fails to validate.
If you remove the getter from the POGO, then the test passes.
This was discovered in building the hibernate-reactive guide where we have the following validated DTO:
https://github.com/micronaut-projects/micronaut-guides/blob/ab0bfb2c117de73b24aabbb9422ec58dadaebb8d/guides/micronaut-hibernate-reactive/java/src/main/java/example/micronaut/SortingAndOrderArguments.java