Propagate more errors to the client side #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves error reporting on the client side. It propagates some errors which were previously only captured on the server side. In particular, it will now: - report which property was being resolved, instead of showing internal `auto.test.resources` properties - capture errors which are sent by the server but were dropped because of lack of JSON error handling - report when a container cannot be started or failed during startup - provide clearer message when the test resources service is down Fixes #444
alvarosanchez
approved these changes
Nov 27, 2023
...urces-client/src/main/java/io/micronaut/testresources/client/DefaultTestResourcesClient.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Serdeable | ||
| public record SimpleJsonErrorModel( | ||
| @JsonProperty("message") String message, |
There was a problem hiding this comment.
Is the annotation needed here?
There was a problem hiding this comment.
It shouldn't, kept it for consistency with the other properties
| return client.resolve(expression, props, properties); | ||
| return withErrorHandling( | ||
| () -> client.resolve(expression, props, properties), | ||
| () -> "Test resources service wasn't able to revolve expression '" + expression + "'" |
There was a problem hiding this comment.
Suggested change
| () -> "Test resources service wasn't able to revolve expression '" + expression + "'" | |
| () -> "Test resources service wasn't able to revolve expression '%s'".formatted(expression) |
Co-authored-by: Álvaro Sánchez-Mariscal <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves error reporting on the client side. It propagates some errors which were previously only captured on the server side. In particular, it will now:
auto.test.resourcespropertiesFixes #444