Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve client side error messages #444

Closed
graemerocher opened this issue Nov 10, 2023 · 0 comments · Fixed by #458
Closed

Improve client side error messages #444

graemerocher opened this issue Nov 10, 2023 · 0 comments · Fixed by #458
Assignees
@melix
Labels
type: improvement A minor improvement to an existing feature

Comments

@graemerocher
Copy link
Contributor

graemerocher commented Nov 10, 2023 •
edited
Loading

Feature description

Currently client side errors are something like ${auto.test.resources.datasources.default.url} cannot be resolved.

We should improve these errors somehow to indicate why:

  • Docker is not running?
  • Test resource server not running?
  • Docker is running but container startup failed -> show error
@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Nov 10, 2023
melix added a commit that referenced this issue Nov 23, 2023
@melix
Propagate more errors to the client side
609d1fc 
This commit improves error reporting on the client side. It propagates
some errors which were previously only captured on the server side.
In particular, it will now:

- report which property was being resolved, instead of showing
internal `auto.test.resources` properties
- capture errors which are sent by the server but were dropped
because of lack of JSON error handling
- report when a container cannot be started or failed during
startup
- provide clearer message when the test resources service is
down

Fixes #444
@melix melix self-assigned this Nov 23, 2023
@melix melix mentioned this issue Nov 23, 2023
Merged
melix added a commit that referenced this issue Nov 27, 2023
@melix @alvarosanchez
Propagate more errors to the client side (#458)
909f3c5 
* Propagate more errors to the client side

This commit improves error reporting on the client side. It propagates
some errors which were previously only captured on the server side.
In particular, it will now:

- report which property was being resolved, instead of showing
internal `auto.test.resources` properties
- capture errors which are sent by the server but were dropped
because of lack of JSON error handling
- report when a container cannot be started or failed during
startup
- provide clearer message when the test resources service is
down

Fixes #444

* Apply suggestions from code review

Co-authored-by: Álvaro Sánchez-Mariscal <[email protected]>

---------

Co-authored-by: Álvaro Sánchez-Mariscal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melix melix

Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate more errors to the client side micronaut-projects/micronaut-test-resources
2 participants
@graemerocher @melix