Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration property allowing users to omit/include the details field #151

Closed
wants to merge 1 commit into from

Conversation

hollingsworthd
Copy link
Contributor

The "details" field of Problem can potentially leak data. Fixes #144.

…d message from returned Problems which fixes #144. Also fix a typo on the field name DEFAULT_STACK_TRACE.
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.5% 90.5% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently breaks binary compatibility.

}

@Controller('/foo')
static class FooController {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotate the controller with @Requires(property = "spec.name", value = "DataLeakageSpec")

@sdelamo
Copy link
Contributor

sdelamo commented Apr 28, 2022

@hollingsworthd I have moved your test to this alternative PR:

#156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Problem Could Cause Information Disclosure
2 participants