BREAKING: don’t expose Exception::getMessage as detail #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless the exception is of type ThrowableProblem or UnsatisfiedRouteException This aims to prevent accidental information leakage. Fixes: #144
sdelamo
added
type: breaking
|
Kudos, SonarCloud Quality Gate passed! |
|
This pull request is an alternative solution to #144. There are some exceptions for which we expose the Let me know what you think. |
hollingsworthd
approved these changes
Apr 28, 2022
|
Looks good. I like the simplicity of the approach and for anything more complicated directing users to override the Java API to customize the returned problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless the exception is of type ThrowableProblem or UnsatisfiedRouteException
This aims to prevent accidental information leakage.
Fixes: #144
Close: #151