Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not creating scopes when resetting scope on trace handler #214

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Not creating scopes when resetting scope on trace handler #214

merged 1 commit into from
Mar 23, 2023

Commits on Mar 23, 2023

  1. Not creating scopes when resetting scope on trace handler 

    without this change, we're using the `tracer.withSpan(null)` to reset the thread local, however the better alternative is to use the `CurrentTraceContext.maybeScope` mechanism.

with this change we're changing the way the `TracingObservationHandler` is clearing scopes. We also needed to improve the testing tracer to support these changes

fixes gh-213
    @marcingrzejszczak
    marcingrzejszczak committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    3071f29 View commit details
    Browse the repository at this point in the history