Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not creating scopes when resetting scope on trace handler #213

Closed
marcingrzejszczak opened this issue Mar 23, 2023 · 0 comments
Closed

Not creating scopes when resetting scope on trace handler #213

marcingrzejszczak opened this issue Mar 23, 2023 · 0 comments
Assignees
@marcingrzejszczak
Labels
bug A general bug
Milestone
1.0.4

Comments

@marcingrzejszczak
Copy link
Contributor

related issue spring-projects/spring-boot#34695
@marcingrzejszczak marcingrzejszczak added the bug A general bug label Mar 23, 2023
@marcingrzejszczak marcingrzejszczak added this to the 1.0.4 milestone Mar 23, 2023
@marcingrzejszczak marcingrzejszczak self-assigned this Mar 23, 2023
marcingrzejszczak added a commit that referenced this issue Mar 23, 2023
@marcingrzejszczak
Not creating scopes when resetting scope on trace handler
3071f29 
without this change, we're using the `tracer.withSpan(null)` to reset the thread local, however the better alternative is to use the `CurrentTraceContext.maybeScope` mechanism.

with this change we're changing the way the `TracingObservationHandler` is clearing scopes. We also needed to improve the testing tracer to support these changes

fixes gh-213
@marcingrzejszczak marcingrzejszczak mentioned this issue Mar 23, 2023
Merged
@marcingrzejszczak marcingrzejszczak mentioned this issue Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcingrzejszczak marcingrzejszczak

Labels
bug A general bug
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
1 participant
@marcingrzejszczak