Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cache for base time unit strings #4487

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Use cache for base time unit strings #4487

merged 2 commits into from
Dec 11, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 10, 2023

This PR changes to use a cache for base time unit strings.

Closes gh-4352

@izeye izeye mentioned this pull request Dec 10, 2023
Closed
@jonatan-ivanov
Copy link
Member

Thank you!
I polished it a bit and added a test.

@jonatan-ivanov jonatan-ivanov linked an issue Dec 11, 2023 that may be closed by this pull request
Base time unit string duplicated for each timer #4352
Closed
@jonatan-ivanov jonatan-ivanov merged commit 0fb75c1 into micrometer-metrics:1.9.x Dec 11, 2023
7 checks passed
@izeye izeye deleted the gh-4352 branch December 11, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base time unit string duplicated for each timer
2 participants
@izeye @jonatan-ivanov