Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base time unit string duplicated for each timer #4352

Closed
DanielThomas opened this issue Nov 12, 2023 · 1 comment · Fixed by #4487
Closed

Base time unit string duplicated for each timer #4352

DanielThomas opened this issue Nov 12, 2023 · 1 comment · Fixed by #4487
Labels
module: micrometer-core An issue that is related to our core module performance Issues related to general performance
Milestone
1.11.7

Comments

@DanielThomas
Copy link

getBaseTimeUnitStr returns a new instance of String for every call, so for services with high tag cardinality, duplicate time units in timers can add up:

micrometer/micrometer-core/src/main/java/io/micrometer/core/instrument/MeterRegistry.java

Line 290 in d6fc0b8

return getBaseTimeUnit().toString().toLowerCase();

Screenshot 2023-11-13 at 10 07 35 am
@shakuzen shakuzen added the performance Issues related to general performance label Nov 13, 2023
@shakuzen shakuzen added this to the 1.9.x milestone Nov 13, 2023
@shakuzen shakuzen added module: micrometer-core An issue that is related to our core module and removed waiting-for-triage labels Nov 13, 2023
izeye added a commit to izeye/micrometer that referenced this issue Dec 10, 2023
@izeye
Use cache for base time unit strings
e81f3d7 
Closes micrometer-metricsgh-4352
@izeye izeye mentioned this issue Dec 10, 2023
Merged
@izeye
Copy link
Contributor

izeye commented Dec 10, 2023

I created #4487 to try to resolve this.

izeye added a commit to izeye/micrometer that referenced this issue Dec 11, 2023
@izeye
Use cache for base time unit strings
a28324b 
Closes micrometer-metricsgh-4352
@jonatan-ivanov jonatan-ivanov modified the milestones: 1.9.x, 1.11.7 Dec 11, 2023
@jonatan-ivanov jonatan-ivanov linked a pull request Dec 11, 2023 that will close this issue
Use cache for base time unit strings #4487
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: micrometer-core An issue that is related to our core module performance Issues related to general performance
Projects
None yet
Milestone
1.11.7
Development

Successfully merging a pull request may close this issue.

Use cache for base time unit strings izeye/micrometer
4 participants
@izeye @DanielThomas @jonatan-ivanov @shakuzen