Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reference the right repo in badges #33

Merged
merged 8 commits into from
Aug 11, 2024

Conversation

dubzzz
Copy link
Contributor

@dubzzz dubzzz commented Aug 8, 2024

Fixing all the links that reference the wrong npm/github locations. Also dropping coverage badge as it seems not to apply anymore.

@dubzzz dubzzz changed the title chore: reference the right repo in badges docs: reference the right repo in badges Aug 8, 2024
@dubzzz
Copy link
Contributor Author

dubzzz commented Aug 8, 2024

@Kikobeats I think there are still some broken references but I'm not sure they got migrated on your hand. Everything linked to Github Pages (github.io links) should probably also referenec new targets if any 🤔

@Kikobeats
Copy link
Member

@dubzzz Thanks a lot!

Can you explain what refernces are still broken?

@dubzzz
Copy link
Contributor Author

dubzzz commented Aug 8, 2024

This one: https://mac-s-g.github.io/react-json-view/demo/dist/ still references the old project and so does not run against your package if I'm not wrong 🤔

@Kikobeats
Copy link
Member

Fixed https://react-json-view.microlink.io/ 🎉

It's possible the demo source code should to be updated, can you take a look if evertyhing looks fine to you?

The demo source code is living at https://github.com/microlinkhq/react-json-view/tree/master/demo/src

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-json-view ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2024 6:56am

@dubzzz
Copy link
Contributor Author

dubzzz commented Aug 9, 2024

I updated the few last references to the original repository. That said I kept the "My email address is listed on my github user page." on the README as I did not know how to update it.

@Kikobeats Kikobeats merged commit 7b1a46f into microlinkhq:master Aug 11, 2024
2 of 3 checks passed
@Kikobeats
Copy link
Member

Kikobeats commented Aug 11, 2024

No worries; I moved relevant information to CONTRIBUTING.md 🙂

@Kikobeats Kikobeats mentioned this pull request Aug 11, 2024
@dubzzz dubzzz deleted the clean-badges branch August 11, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants