Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview of German #31

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Preview of German #31

merged 2 commits into from
Jan 25, 2024

Conversation

microbit-matt-hillsdon
Copy link

No description provided.

Comment on lines 36 to 38
"expectedIn": "„in“ fehlt.",
"expectedIndentedBlock": "Einrückung fehlt",
"expectedInExpr": "Fehlender Ausdruck nach \"in\"",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mix of quote types. Some are " and some are „

There doesn't seem to be any logic to this. See in in expectedIn and expectedInExpr.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll raise this with Emma to feed back to the translator/proofreader.

"memberDelete": "Kann Mitglied \"{name}\"für Typ \"{type}\" nicht löschen",
"memberSet": "Kann Mitglied \"{name}\" nicht für Typ \"{type}\" zuweisen",
"moduleNotCallable": "Modul ist nicht abrufbar.",
"moduleUnknownMember": "„{name}“ ist kein bekanntes Mitglied des Moduls „{module}“.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few unexpected full stops, mostly towards the end of the file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may as well fix these

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised with Emma as they've been introduced recently

@microbit-matt-hillsdon
Copy link
Author

Happy with this as a preview now. Merging.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 5fba0c6 into microbit Jan 25, 2024
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the translations branch January 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants