Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code.org Integration #3

Merged

Conversation

epeach
Copy link
Contributor

@epeach epeach commented Dec 12, 2019

These changes facilitate the integration of the MicroBit Firmata client code into the Code.org repository: https://github.com/code-dot-org/code-dot-org.

This PR contains 3 changes:

  • Allow serialport to be overridden in the constructor so that we can provide our own implementation.
  • Detect when this code is run in a browser and use the global TextEncoder/Decoder in that case.
  • Return a promise from connect and setSerialPort so that client code can determine when those functions are complete.

cc: @joshlory

@JohnVidler
Copy link
Collaborator

Sorry this has taken so long to address.

This looks like a reasonable set of changes with minimal impact on our own tests, so lets just get this merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants