Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add microbit firmata (1) #32396

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Add microbit firmata (1) #32396

merged 3 commits into from
Dec 13, 2019

Conversation

epeach
Copy link

@epeach epeach commented Dec 12, 2019

Description

This adds this microbit firmata to our third-party code folder: https://github.com/microbit-foundation/microbit-firmata

It includes the changes that are pending in this PR: microbit-foundation/microbit-firmata#3

There are eventual plans to reference this code from the package.json once that^ PR has been accepted and after the demo.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

cc: @joshlory

@epeach epeach changed the title Add microbit firmata Add microbit firmata (1) Dec 12, 2019
@epeach epeach merged commit 98aa3ce into staging-next Dec 13, 2019
@epeach epeach deleted the add-microbit-firmata branch December 13, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants