Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279
The build process for
submission-schema
relies onsheets_and_friends
to copy over certain schema elements fromnmdc-schema
intosubmission-schema
. It also does a bit of graph-walking to also bring in the necessary dependent elements of the copied ones (e.g. if you copy over a subclass you also need to copy over its superclass). Somehow this ends up copying over more than we actually need. Instead of addressing it at thesheets_and_friends
level, we've gotten into the habit of sort of papering over the issue by usingyq
to blast away the elements we know we don't need.The changes to
nmdc-schema
between v11.1.0 and v11.2.1 introduced new schema elements thatsubmission-schema
doesn't need, along with relations between them and existing schema elements, e.g.OntologyClass
(existing) is related toOntologyRelation
(new) via arelations
slot (also new). Since we were usingyq
to remove some of those existing schema elements, these changes useyq
to also remove the new ones.Some day we should really fix this at the
sheets_and_friends
level, so that the manual intervention withyq
isn't needed. But that day isn't today.