Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nmdc-schema v11.2.1 #281

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

pkalita-lbl
Copy link
Collaborator

Fixes #279

The build process for submission-schema relies on sheets_and_friends to copy over certain schema elements from nmdc-schema into submission-schema. It also does a bit of graph-walking to also bring in the necessary dependent elements of the copied ones (e.g. if you copy over a subclass you also need to copy over its superclass). Somehow this ends up copying over more than we actually need. Instead of addressing it at the sheets_and_friends level, we've gotten into the habit of sort of papering over the issue by using yq to blast away the elements we know we don't need.

The changes to nmdc-schema between v11.1.0 and v11.2.1 introduced new schema elements that submission-schema doesn't need, along with relations between them and existing schema elements, e.g. OntologyClass (existing) is related to OntologyRelation (new) via a relations slot (also new). Since we were using yq to remove some of those existing schema elements, these changes use yq to also remove the new ones.

Some day we should really fix this at the sheets_and_friends level, so that the manual intervention with yq isn't needed. But that day isn't today.

@pkalita-lbl pkalita-lbl merged commit 9ff3e04 into main Dec 9, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the issue-279-nmdc-schema-11.2.1 branch December 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update submission schema to use nmdc-schema version 11.2.1
1 participant