-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post-voting env triad value set serialization #280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbomam
changed the title
Multi pass duckdb
Improvements to Voting sheet generation and BioSamples DuckDB generation
Dec 11, 2024
turbomam
requested review from
pkalita-lbl,
sierra-moxon,
aclum and
mslarae13
December 12, 2024 18:41
I believe this is getting moved out of submission-schema and into a different repo. |
turbomam
changed the title
Improvements to Voting sheet generation and BioSamples DuckDB generation
post-voting env triad value set serialization
Dec 17, 2024
cmungall
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: I might be able to remove some of the dependencies added to pyproject.toml
@pkalita-lbl can you accept these changes, especially the new dev dependencies imports in pyproject.toml?
This is in support of the post-voting phase of environmental context/environmental triad vale sets
@sierra-moxon I think you has talked about doing code review and providing documentation at some point. I have added a lot of inline Markdown in the notebook, but would still welcome your review
@cmungall I've added you as a reviewer since you showed interest in annotating the post-voting notebooks, and for you to sign off on the new soil env_local_scale enumeration