Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-voting env triad value set serialization #280

Merged
merged 50 commits into from
Dec 18, 2024
Merged

Conversation

turbomam
Copy link
Member

@turbomam turbomam commented Dec 9, 2024

UPDATE: I might be able to remove some of the dependencies added to pyproject.toml


@pkalita-lbl can you accept these changes, especially the new dev dependencies imports in pyproject.toml?

This is in support of the post-voting phase of environmental context/environmental triad vale sets

@sierra-moxon I think you has talked about doing code review and providing documentation at some point. I have added a lot of inline Markdown in the notebook, but would still welcome your review

@cmungall I've added you as a reviewer since you showed interest in annotating the post-voting notebooks, and for you to sign off on the new soil env_local_scale enumeration

@turbomam turbomam changed the title Multi pass duckdb Improvements to Voting sheet generation and BioSamples DuckDB generation Dec 11, 2024
@mslarae13
Copy link
Contributor

I believe this is getting moved out of submission-schema and into a different repo.
I'll review when the new PR is opened

@turbomam turbomam changed the title Improvements to Voting sheet generation and BioSamples DuckDB generation post-voting env triad value set serialization Dec 17, 2024
@turbomam turbomam requested a review from cmungall December 17, 2024 21:57
@turbomam turbomam merged commit 2c76cd9 into main Dec 18, 2024
2 checks passed
@turbomam turbomam deleted the multi-pass-duckdb branch December 18, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants