Add makefile targets to test and build docs locally, make sure ingest-triad results are injected into docs #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get to run locally so that we can see that the triad terms are added to doc locally
… of having one way to test that docs are fully realized including all the component generation steps
sierra-moxon
requested review from
pkalita-lbl and
turbomam
and removed request for
pkalita-lbl
pkalita-lbl
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GH action workflows and the makefile targets in Makefile and project.Makefile are the key changes here to review. The rest of the changes come from me regenerating things via the new target
test_deploy_docs_actionthat tries to mimic the docs deployment from a single make target locally.I ran the new target locally and checked out the docs - I see the new triad terms in order alphabetically in my local copy of the docs. I'd like to try and merge this in, to make sure that the GH actions are similarly successful.