Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PV terms from env triad to schema #260

Merged
merged 13 commits into from
Nov 11, 2024
Merged

add PV terms from env triad to schema #260

merged 13 commits into from
Nov 11, 2024

Conversation

sierra-moxon
Copy link
Member

No description provided.

@sierra-moxon sierra-moxon marked this pull request as ready for review November 7, 2024 00:49
@turbomam
Copy link
Member

I approve this but think we should merge this in first. Might require you to change some paths in your scripts or Makefile targets

@sierra-moxon
Copy link
Member Author

@turbomam - pls review when you have time, I can't merged without an official review. scripts are updated to take the changes in filepaths from your PR.

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@turbomam turbomam merged commit 5067032 into main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants