Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save local/from_schemasheets yaml and retire makefile target that builds it #231

Conversation

turbomam
Copy link
Member

No description provided.

@turbomam turbomam marked this pull request as ready for review October 28, 2024 15:30
Copy link
Collaborator

@pkalita-lbl pkalita-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. If you want to track that as a separate issue that's fine with me. Either way, feel free to merge when you're ready.

uri: xsd:language
enums:
BioticRelationshipEnum:
description: placeholder enum descr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to remove all these placeholder descriptions with this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I thought I had. Maybe that was in some different project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turbomam turbomam merged commit 23361ff into main Oct 28, 2024
2 checks passed
@turbomam turbomam deleted the 229-save-localfrom_schemasheetsyaml-and-retire-makefile-target-that-builds-it branch October 28, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save the content in local/from_schemasheets.yaml and retire makefile target that builds it
2 participants