add "none" to slot analysis/data type

[bmeluch]

From #166, added "none" to AnalysisTypeEnum

[pkalita-lbl]

Sorry for not looking at issue #166 sooner. I just read through it and it's not clear to me if this change needs to be here or in nmdc-schema. Hold tight until we get an update in the issue.

[turbomam]

What's the case in which the analysis_type would be 'none'?

Adding 'none' to a list of categorical values is very controversial. Some terminological resources do it extensively (like NCIT, I think) but I don't think we have done this in the nmdc-schema yet and I would prefer not to start.

The slot is recommended, not required in nmdc-schema, but it appears to be required in the submission-schema.

[pkalita-lbl]

What's the case in which the analysis_type would be 'none'?

It's outlined in the linked issue #166

[mslarae13]

@bmeluch
Change 'none' to "bulk chemistry"

[mslarae13]

@pkalita-lbl should this change also be made in NMDC schema?

I think the answer is yes, though I don't think we track this in nmdc-main. So maybe it's not important for data but would be good for consistancy.
Would like @pkalita-lbl , @turbomam to comment

@bmeluch
See https://github.com/microbiomedata/nmdc-schema/blob/f2690e865b41893cc8dbd519434052087d48e559/src/schema/portal/sample_id.yaml#L24

[pkalita-lbl]

should this change also be made in NMDC schema?

It should only be made in nmdc-schema. The fact that submission-schema was redefining AnalysisTypeEnum was a mistake that I fixed recently (which is also why this PR has merge conflicts).

The path forward should be:

• Close this PR
• Make the change in nmdc-schema (Montana has correctly pointed out where to make the change)
• When a new version of nmdc-schema has been released with that change, update sheets_and_friends/tsv_in/import_slots_regardless.tsv in this repo to import the new version