Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease reliance on yq #39

Open
turbomam opened this issue Mar 17, 2023 · 2 comments
Open

Decrease reliance on yq #39

turbomam opened this issue Mar 17, 2023 · 2 comments
Assignees
Labels

Comments

@turbomam
Copy link
Member

Any use of yq should be compact, general and well-documented. It should not be used to apply name-based modifications which can be handled by sheets_and_friends' modifications_and_validation script.

Currently, the validation updates specified by the --validation_config_tsv argument are only triggered when detecting

  • specified slot ranges
  • specified slot string_serializations

and only take these actions:

  • overwriting a slot's pattern
  • overwriting a slot's DH datatype... which is just a type range as an xsd CURIE?

I don't think the DH datatype changes are necessary any more, as class ranges are generally replaced by the yq operations, and DH seems to understand the range specifications that consist of a linkml:type in name alone.

I would like to continue using yq for these general validation updates, or add additional trigger types to modifications_and_validation.

cc @pkalita-lbl

@turbomam turbomam self-assigned this Mar 17, 2023
@turbomam
Copy link
Member Author

turbomam commented Mar 17, 2023

@mslarae13
Copy link
Contributor

Does this relate to microbiomedata/nmdc-schema#1846 ??
@sierra-moxon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants