Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move yq commands out of project.Makefile and into a configuration file #178

Open
turbomam opened this issue Jan 25, 2024 · 5 comments · May be fixed by #198
Open

move yq commands out of project.Makefile and into a configuration file #178

turbomam opened this issue Jan 25, 2024 · 5 comments · May be fixed by #198
Assignees
Labels

Comments

@turbomam
Copy link
Member

turbomam commented Jan 25, 2024

see

@turbomam turbomam self-assigned this Jan 25, 2024
@mslarae13
Copy link
Contributor

@turbomam what is left to do here if the PR is closed?

@mslarae13
Copy link
Contributor

Depends on decision around schema vs submission-schema
Mark said would take a few hours to complete.

yq vs sheets-and-friends decision also needed. vs tsv_in files (Patrick and Mark to decide method of managing /capturing these difference)

Blocked until decision made.

@turbomam
Copy link
Member Author

This is somewhat in contradiction to

I'm still feeling wishy-washy about more vs less use of yq

But this PR will make the project.Makefile easier to read.

@turbomam turbomam linked a pull request May 22, 2024 that will close this issue
@mslarae13
Copy link
Contributor

@turbomam who should weigh in on making this decision?

@mslarae13
Copy link
Contributor

Which .yaml manipulating methods are preferred?

yq files are handling the mapping of nmdc-schema to submissions-schema and come after sheets and friends.

  • If it works and makes the correct translation, it's not high priority.
  • would prefer this be done in a more uniform way.

Maintainability aspect would be easier if it was a standard shell script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants