-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API calls in NOM visualizations to reflect Berkeley schema #80
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -9,7 +9,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -10,7 +10,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find the "data generation records" rather than "omics processing records" (first sentence). Also "input to the omics processing records" in last sentence should be "data generation records"
Reply via ReviewNB
@@ -10,7 +10,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #1. omicsprocess_dataobj=func.get_id_results(
Change the name of the python objects to remove "omicsprocessing" please.
Reply via ReviewNB
@@ -10,7 +10,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @samobermiller and @bmeluch. I found a few references to "omics processing" that should be "data generation", but the functionality looks great. |
@@ -10,7 +10,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "Find the omics processing records" to "Find the data generation records" Also, change the variables from omics_processing_id
omicsprocess_has_output
omicsprocess_has_input
to allude to data generation.
Reply via ReviewNB
@@ -10,7 +10,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "omics processing" to "data generation" And change variable (mentioned in comment above too) for omicsprocess_has_input
to allude to data generation instead.
Reply via ReviewNB
These make sense! I guess in the back of my head I was thinking theyre still technically omics records, but I see thats its confusing cause we query data generation |
I think Katherine and I must have reviewed at the same time. I had similar comments. |
…cessing to data generation
PR updating API calls in NOM visualizations to Berkeley schema. microbiomedata/issues#726
All Submissions:
Notebook Fix Submissions: