Remove gh workflow for checking links on Pull Requests #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynnz22
approved these changes
Sep 18, 2024
also add check for adding to github workflow
samobermiller
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
This PR also makes a small change to the PR template (fixes a link and adds a check/question about adding a github workflow test with each new notebook)
This MR removes the github workflow that checks links on merge requests. Links are still checked daily and reported as issues if non-resolvable. Workflow can also be manually triggered if wanted.
Thanks @samobermiller for bringing this to our attention!
All Submissions:
Fixes [BUG] github workflow fails with "not valid yet links" #71